Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Add guides to setup Cobbler in libvirt #178

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

SchoolGuy
Copy link
Member

This PR aims to add three new posts:

  1. Basic setup to automate installing inside the libvirt network.
  2. State of the project
  3. Advances setup to automate installing both inside and outside of a libvirt network.

@ycedres ages ago you said that you are interested to have such a setup at home. I would kindly ask you to help me co-author this blog post and check what I described in these posts.

@SchoolGuy SchoolGuy requested a review from ycedres May 6, 2023 12:04
@SchoolGuy SchoolGuy force-pushed the blog/add-libvirt-guides branch 2 times, most recently from da2e63f to 909b29a Compare May 6, 2023 12:32
Copy link
Contributor

@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to give it another look, these two nitpicks I found so far.

_posts/2023/2023-02-15-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-02-15-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
@SchoolGuy
Copy link
Member Author

Thanks for the suggestions @ByteOtter. I would like us to sit down next week and fix these things together. My writing skills are not the best and as such I am deeply dependant on your input and help.

@SchoolGuy SchoolGuy force-pushed the blog/add-libvirt-guides branch 2 times, most recently from 630e8c3 to 89b6f19 Compare December 28, 2023 17:19
@SchoolGuy
Copy link
Member Author

SchoolGuy commented Dec 28, 2023

The first guide works as good as it possibly can atm. The second guide will be extended tomorrow.

Edit: Doing this with openSUSE wasn't a good idea it seems. The template is horribly outdated it seems. I will try and fix that after this PR is in with 3.3.4...

Copy link
Contributor

@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over the first article and added some comments. Most of them are simple wording or grammar nitpicks which you can accept at your discretion.

Apart from that I liked the guide generally, though I do have some personal gripes with it.
Some of the steps, while it is clear what to do, do not provide a reason why you do this. What the step is good for and why Cobbler requires it to be done this way. Maybe you could add a couple more sentences here and there to explain why we are doing this.
If these intricacies are already explained elsewhere a link to another article would be great too.

_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
@SchoolGuy SchoolGuy removed the request for review from ycedres December 30, 2023 14:44
@SchoolGuy SchoolGuy marked this pull request as ready for review December 31, 2023 08:29
Copy link
Contributor

@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went over and suggested some annotations. Again, mostly smaller nitpicks here and there about punctuation and wording.
Other than that I like how you expanded the articles, they are much more coherent and easier to follow and understand.

_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-07-cobbler-inside-libvirt-1.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-08-cobbler-inside-libvirt-2.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-08-cobbler-inside-libvirt-2.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-08-cobbler-inside-libvirt-2.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-08-cobbler-inside-libvirt-2.md Outdated Show resolved Hide resolved
_posts/2023/2023-07-08-cobbler-inside-libvirt-2.md Outdated Show resolved Hide resolved
Co-authored-by: Christopher Hock <christopher.hock@suse.com>
@SchoolGuy SchoolGuy merged commit c04214a into main Jan 2, 2024
1 check passed
@SchoolGuy SchoolGuy deleted the blog/add-libvirt-guides branch January 14, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants