Makefile: Update Cockpit lib to 35090b743b6b4536fc9c09cd9644c1c3

[github-actions]

Jelle van der Waa (9):
base1: correct typeof invocation
lib: correctly check if rows are empty
lib: cockpit: rename location to location-utils
lib: cockpit: split location into a separate class
metrics: don't divide a number with a string
lib: correct DbusClient.proxy() typing
lib: add DbusClient.watch() in TypeScript typing
lib: allow cockpit.location to be modified
test: typecheck: output stats of TS errors for JavaScript files

Marius Vollmer (11):
lib: Adapt TypeaheadSelect and MultiTypeaheadSelect to key navigation changes
lib: Add useOn hook, for our own EventEmitter
lib: Import SimpleSelect template from PatternFly
lib: Correct TypeScript errors in SimpleSelect
lib: Make our changes to SimpleSelect
lib: Use SimpleSelect for ServerTime
lib: Use SimpleSelect for ShutdownModal
lib: Use SimpleSelect for FirewalldRequest
lib: Don't apply double spacing fix globally to all dropdowns
lib: Explicitly use white background color for MenuToggle
test: Remove Browser.select_PF_deprecated

Martin Pitt (10):
build: Move to es2021
networkmanager, systemd: Fix boolean or operators
lib: cockpit.channel.wait() takes an optional callback
playground, shell: Add type assertions for external dict lookups
shell: Robustify final_countdown
shell: Don't add string and number
test: Avoid parentheses for tuples in subscripts
test: Annotate js_error_codes type
Use raw strings with re functions
Don't mark used function arguments as dummy

[jelly]

Same issue as @martinpitt noted here cockpit-project/cockpit-files#875 (comment) lets hold the update back

[jelly]

Same issue as @martinpitt noted here cockpit-project/cockpit-files#875 (comment) lets hold the update back

We agreed in Matrix that the pixel tests are an acceptable change

[martinpitt]

OK - I still found the previous version better, the new one looks unbalanced. But let's not block on that.

[mvollmer]

OK - I still found the previous version better, the new one looks unbalanced. But let's not block on that.

The new ones are "correct", see cockpit-project/cockpit#21356 (comment).

Check this pixel diff for example: https://github.com/cockpit-project/pixel-test-reference/compare/ae227eac212cf8800ea60c51bb8a7f4d4a8437ec..297cff9af900cc21c88c7e9d82a3c88600f90cdf#diff-7ebbee5bf5cb99723cc58e1337c828a933ef45b7eb9e1f9342be9ab3c19dc879

Before, "VNC console" and "Send key" had different margins to to the right of the triangle. After, they look consistent.

The "after" look for "Send key" is how all dropdowns look with default Patternfly.

[martinpitt]

@mvollmer ah yes, that's exactly the change were I said "that's a regression, let's do a follow-up". My sense of symmetry and beauty just doesn't align with PF any more 😬