Skip to content

Commit

Permalink
lib: Don't apply double spacing fix globally to all dropdowns
Browse files Browse the repository at this point in the history
So that the SimpleSelect template looks like the deprecated Select
that it is replacing, and like the FormSelect that we are also using.

Instead, fix the dropdown margings in the Shell masthead, to keep them
as they were.
  • Loading branch information
mvollmer committed Dec 4, 2024
1 parent 8f07232 commit 0b9fea2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 0 additions & 6 deletions pkg/lib/patternfly/patternfly-5-overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ select.pf-v5-c-form-control {
margin: 0;
}

// Fix the double-spacing issue for other dropdowns
// https://github.com/patternfly/patternfly/issues/6632
.pf-v5-c-menu-toggle__controls:last-child > .pf-v5-c-menu-toggle__toggle-icon {
margin-inline-end: 0;
}

// Fix menus cropping contents
// https://github.com/patternfly/patternfly/issues/6565
.pf-v5-c-menu__item-text {
Expand Down
6 changes: 6 additions & 0 deletions pkg/shell/shell.scss
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,12 @@ $desktop: $phone + 1px;
--pf-v5-global--Color--100: var(--pf-v5-global--Color--dark-100);
}

// The normal margin to the right of the select dropdown makes them look uncentered in the masthead.
// https://github.com/patternfly/patternfly/issues/6632
.pf-v5-c-masthead .pf-v5-c-menu-toggle__controls:last-child > .pf-v5-c-menu-toggle__toggle-icon {
margin-inline-end: 0;
}

// Customize the about screen with the Cockpit logo
.pf-v5-c-about-modal-box {
--pf-v5-c-about-modal-box--BackgroundImage: linear-gradient(#000d, #000d), url(../shell/images/cockpit-icon.svg);
Expand Down

0 comments on commit 0b9fea2

Please sign in to comment.