Localize times

[marusak]

Fixes #8583
I haven't found any other place, where the format would not be localized. If you find something, please point it out, and I'll fix it out.
The only other place related to time, that should be localized, are calendars:

(names of days, on which day week starts... - this can be done with setting up language but it requires to import all locale files - which cannot be automated... But there are also other options, so I just plan to open issue for that and take a look at it separately).

I am not sure about that change on the overview page. It seems so obvious that I doubt it was not purposely that way? Now looks like this in English and is localized:

Is that right?

Likely breaks tests, so spinning them out

[martinpitt]

I am not sure about that change on the overview page

In master I see "2020-02-04 16:19" right now, which is ISO format; both in German and in English. I suppose that works in every language, but indeed it seems fine to actually localize it.

[martinpitt]

Looks mostly good, thanks! Please remember to add a Closes # still, when the tests come back.

[martinpitt]

I think it should rather live in pkg/systemd/overview.jsx . @allisonkarlitskaya needs that for PR #13473 as well.

[martinpitt]

LGTM now, thanks! I suppose this will fail on -distropkg, though.

[vieira-temes]

Sorry if this is not the appropriate place to ask, but is it possible to have the language set to en_us but with a 24 hour format? How?

[martinpitt]

@PabloGrok : You'd need to pick a locale with 24 hour format, perhaps en_GB?

[vieira-temes]

But I don't want British idioms in the UI. Shouldn't time formats be decoupled from locales?

[martinpitt]

Unfortunately browsers don't have the fine-grained locale configuration like Linux has (LC_TIME, LC_MONETARY, LC_MESSAGES and such).

[garrett]

Additionally, the first day of the week is different in various places.

https://en.wikipedia.org/wiki/Week#/media/File:First_Day_of_Week_World_Map.svg

And either we're assuming English means US and have German incorrect, or we (or PF) hardcode the first day of the week as Sunday:

PatternFly has a weekStart option. I guess we're not handling that with locales and/or not passing it to the PF widget:

Name	Type	Default	Description
weekStart	0 | 1 | 2 | 3 | 4 | 5 | 6 | Weekday		Day of week that starts the week. 0 is Sunday, 6 is Saturday.

[martinpitt]

@garrett : Indeed -- eww, that sucks. Standard Unix/Linux locale information has had that piece of information forever:

❱❱❱ LC_TIME=en_US.UTF-8 locale -k -c LC_TIME | grep first_weekday
first_weekday=1

❱❱❱ LC_TIME=de_DE.UTF-8 locale -k -c LC_TIME | grep first_weekday
first_weekday=2

However, I didn't find anything in Intl which would expose that piece of information to JS. There is a JS standard issue about this very topic: tc39/ecma402#6 but it has been open for 6 years now (but there is some progress).

So I'm afraid right now the only thing which we can do is to keep a copy of that information in our pkg/lib. I'll look into it.

[martinpitt]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/weekInfo would be that, but it doesn't work in Firefox, Chromium, nor node.js.

[martinpitt]

I sent PR 16587 to at least fix this for most users.