lib: Port us away from deprecated Select variant "checkbox" #21373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
added
no-test
mvollmer
force-pushed
the
lib-checkbox-select
branch
2 times, most recently
from
860f19b to
0ea56f3
Compare
mvollmer
removed
the
no-test
mvollmer
force-pushed
the
lib-checkbox-select
branch
from
0ea56f3 to
fcab3a0
Compare
mvollmer
removed
the
blocked
mvollmer
force-pushed
the
lib-checkbox-select
branch
from
fcab3a0 to
fbab4c0
Compare
mvollmer
force-pushed
the
lib-checkbox-select
branch
2 times, most recently
from
37773f5 to
b23372d
Compare
|
@mvollmer removing from my review queue as this is still red. I rather dislike that we have to take on more and more PF code with what should be generic upstream components, but alas.. 🤷♂️ Thanks for working on this! |
From 3b857f8b06440bccc8e7979cf686f4e3261ff4df
Let's wait for the #services-list element to be there before looking into it.
mvollmer
force-pushed
the
lib-checkbox-select
branch
from
b23372d to
27a0d5f
Compare
cockpituous
reviewed
Dec 19, 2024
| const { content, value, key, ...props } = option; | ||
| const isSelected = selected.includes(value); | ||
| return ( | ||
| <SelectOption value={value} key={key !== undefined ? key : `${value}`} |
There was a problem hiding this comment.
This added line is not executed by any test.
| }); | ||
|
|
||
| const onToggleClick = () => { | ||
| onToggle && onToggle(!isOpen); |
There was a problem hiding this comment.
This added line is not executed by any test.
| selected={selected} | ||
| onSelect={_onSelect} | ||
| onOpenChange={(isOpen) => { | ||
| onToggle && onToggle(isOpen); |
There was a problem hiding this comment.
This added line is not executed by any test.
|
I think the remaining failures are flakes, amplified by repeating agffected tests: I can't reproduce them locally... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.