test: Wait for TypeaheadSelect to settle down before pressing keys #21411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TypeaheadSelect template code will focus the text input 100ms after opening the menu. The tests generally aren't disturbed about that, except when simulating key presses, of course. When the focus unexpectedly shifts back to the text input while navigating the menu items, the focused item is reset to either the first or last one.
|
This should help with #21399. (I pushed it there as well, but I am unsure of how to best resolve the conflict there.) |
Amazing... I must have been really confused when testing this locally. |
mvollmer
added
the
no-test
Ahh... there actually is a difference with new PF. More yaks! |
|
Alright, the focus shifting only happens with the PF update in #21399. Without it, the text input remains focused throughout the test and there should be no race. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeaheadSelect template code will focus the text input 100ms after opening the menu. The tests generally aren't disturbed about that, except when simulating key presses, of course.
When the focus unexpectedly shifts back to the text input while navigating the menu items, the focused item is reset to either the first or last one.