lib: Remove custom key navigation from TypeaheadSelect #21412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TypeaheadSelect template code will focus the text input 100ms after opening the menu. The tests generally aren't disturbed about that, except when simulating key presses, of course. When the focus unexpectedly shifts back to the text input while navigating the menu items, the focused item is reset to either the first or last one.
It's not helping.
mvollmer
force-pushed
the
lib-no-custom-menu-keynav
branch
from
6f2f191 to
20b87ec
Compare
cockpituous
reviewed
Dec 9, 2024
Comment on lines
+34
to
+35
| function add(val: string | number) { | ||
| setSelected(selected.concat([val])); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
Comment on lines
+38
to
+39
| function rem(val: string | number) { | ||
| setSelected(selected.filter(v => v != val)); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
| id='multi-typeahead-widget' | ||
| placeholder="Select flavors" | ||
| isScrollable | ||
| noOptionsFoundMessage={notFoundIsString ? "Not found" : val => cockpit.format("'$0' not found", val) } |
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+53
to
+54
| onToggle={() => setToggles(val => val + 1)} | ||
| onInputChange={() => setChanges(val => val + 1)} |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
| id="notFoundIsStringMulti" | ||
| label="notFoundIsString" | ||
| isChecked={notFoundIsString} | ||
| onChange={(_event, checked) => setNotFoundIsString(checked)} |
There was a problem hiding this comment.
This added line is not executed by any test.
|
This only works with the PF coming in #21399. Before that, the text input keeps its focus and the template does indeed handle all key presses for the menu navigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not helping.