lib: Make SimpleSelect and CheckboxSelect generic in the option value type #21454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
force-pushed
the
lib-generic-selects
branch
from
86e9063 to
6b84afe
Compare
martinpitt
reviewed
Dec 19, 2024
… type The "forwarded ref" machinery has been removed. We probably don't need it, I don't know how to make it work with the generics, and it is deprecated in React 19.
mvollmer
force-pushed
the
lib-generic-selects
branch
from
6b84afe to
a47e20c
Compare
martinpitt
approved these changes
Dec 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.