testserver: run cockroach with Pdeathsig on linux #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the test crashes for whatever reason and does not run the deferred cleanup, then we would like very much for the operating system to kill the subprocess. Linux has nice support for this.
|
This change is |
andreimatei
reviewed
Apr 9, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
|
I don't know why the SIGSEGV is happening but I stumbled upon this: golang/go#27505 (comment) Do you think we need something like that? Do we need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the test crashes for whatever reason and does not run the deferred
cleanup, then we would like very much for the operating system to kill
the subprocess. Linux has nice support for this.