-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support restarting / upgrading nodes #141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardJCai
force-pushed
the
support_reset_server
branch
4 times, most recently
from
June 21, 2022 15:05
c33f086
to
f6aac83
Compare
RichardJCai
force-pushed
the
support_reset_server
branch
from
June 21, 2022 15:12
f6aac83
to
fa1f424
Compare
ZhouXing19
requested changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit comments
ZhouXing19
requested changes
Jun 21, 2022
Right now this is only supported in insecure mode. Start a three node cluster using the ThreeNode TestsServerOpt.
RichardJCai
force-pushed
the
support_reset_server
branch
from
June 21, 2022 20:00
885cac3
to
bc0e582
Compare
ZhouXing19
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just some very minor nits.
ZhouXing19
reviewed
Jun 22, 2022
RichardJCai
force-pushed
the
support_reset_server
branch
from
June 22, 2022 15:29
bc0e582
to
a7906e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.