Skip to content

Commit

Permalink
codeowners, roachtest: merge SQL schema + sessions to SQL foundations
Browse files Browse the repository at this point in the history
The SQL Schema and Sessions teams are merging to form SQL
Foundations. As described in DEVINFHD-867 we want to:

- reroute old teams to new sql-foundations team
- rename "SQL Schema" project to "SQL Foundations"
- deprecate "SQL Sessions" project

Release note: None
  • Loading branch information
celiala committed May 9, 2023
1 parent cb14c18 commit 3280302
Show file tree
Hide file tree
Showing 40 changed files with 124 additions and 130 deletions.
136 changes: 68 additions & 68 deletions .github/CODEOWNERS

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions TEAMS.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,13 @@ cockroachdb/docs:
triage_column_id: 3971225
aliases:
cockroachdb/docs-infra-prs: other
cockroachdb/sql-sessions:
cockroachdb/sql-foundations:
aliases:
cockroachdb/sql-syntax-prs: other
cockroachdb/sqlproxy-prs: other
cockroachdb/sql-api-prs: other
triage_column_id: 7259065
label: T-sql-sessions
cockroachdb/sql-schema:
triage_column_id: 8946818
label: T-sql-foundations
cockroachdb/sql-queries:
aliases:
cockroachdb/sql-optimizer: other
Expand Down
5 changes: 2 additions & 3 deletions pkg/cmd/roachtest/registry/owners.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,15 @@ type Owner string

// The allowable values of Owner.
const (
OwnerSQLSessions Owner = `sql-sessions`
OwnerDisasterRecovery Owner = `disaster-recovery`
OwnerCDC Owner = `cdc`
OwnerDisasterRecovery Owner = `disaster-recovery`
OwnerKV Owner = `kv`
OwnerReplication Owner = `replication`
OwnerAdmissionControl Owner = `admission-control`
OwnerObsInf Owner = `obs-inf-prs`
OwnerServer Owner = `server` // not currently staffed
OwnerSQLFoundations Owner = `sql-foundations`
OwnerSQLQueries Owner = `sql-queries`
OwnerSQLSchema Owner = `sql-schema`
OwnerStorage Owner = `storage`
OwnerTestEng Owner = `test-eng`
OwnerDevInf Owner = `dev-inf`
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/roachtest/tests/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ go_library(
"@com_github_dustin_go_humanize//:go-humanize",
"@com_github_google_go_cmp//cmp",
"@com_github_jackc_pgtype//:pgtype",
"@com_github_jackc_pgx_v4//:pgx",
"@com_github_kr_pretty//:pretty",
"@com_github_lib_pq//:pq",
"@com_github_montanaflynn_stats//:stats",
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/activerecord.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ func registerActiveRecord(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "activerecord",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Timeout: 5 * time.Hour,
Cluster: r.MakeClusterSpec(1),
NativeLibs: registry.LibGEOS,
Expand Down
6 changes: 3 additions & 3 deletions pkg/cmd/roachtest/tests/alterpk.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,15 +179,15 @@ func registerAlterPK(r registry.Registry) {
}
r.Add(registry.TestSpec{
Name: "alterpk-bank",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
// Use a 4 node cluster -- 3 nodes will run cockroach, and the last will be the
// workload driver node.
Cluster: r.MakeClusterSpec(4),
Run: runAlterPKBank,
})
r.Add(registry.TestSpec{
Name: "alterpk-tpcc-250",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
// Use a 4 node cluster -- 3 nodes will run cockroach, and the last will be the
// workload driver node.
Cluster: r.MakeClusterSpec(4, spec.CPU(32)),
Expand All @@ -197,7 +197,7 @@ func registerAlterPK(r registry.Registry) {
})
r.Add(registry.TestSpec{
Name: "alterpk-tpcc-500",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
// Use a 4 node cluster -- 3 nodes will run cockroach, and the last will be the
// workload driver node.
Cluster: r.MakeClusterSpec(4, spec.CPU(16)),
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/asyncpg.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func registerAsyncpg(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "asyncpg",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1, spec.CPU(16)),
Tags: registry.Tags(`default`, `orm`),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/roachtest/tests/awsdms.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import (
"github.com/cockroachdb/cockroach/pkg/util/retry"
"github.com/cockroachdb/cockroach/pkg/util/version"
"github.com/cockroachdb/errors"
"github.com/jackc/pgx/v4"
"google.golang.org/protobuf/proto"
)

Expand Down Expand Up @@ -189,7 +188,7 @@ func dmsDescribeTasksInput(
func registerAWSDMS(r registry.Registry) {
r.Add(registry.TestSpec{
Name: "awsdms",
Owner: registry.OwnerSQLSessions, // TODO(otan): add a migrations OWNERS team
Owner: registry.OwnerSQLFoundations, // TODO(otan): add a migrations OWNERS team
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `awsdms`, `aws`),
Run: runAWSDMS,
Expand Down
6 changes: 3 additions & 3 deletions pkg/cmd/roachtest/tests/connection_latency.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func registerConnectionLatencyTest(r registry.Registry) {
numNodes := 3
r.Add(registry.TestSpec{
Name: fmt.Sprintf("connection_latency/nodes=%d/certs", numNodes),
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
// Add one more node for load node.
Cluster: r.MakeClusterSpec(numNodes+1, spec.Zones(regionUsCentral)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand All @@ -135,7 +135,7 @@ func registerConnectionLatencyTest(r registry.Registry) {

r.Add(registry.TestSpec{
Name: fmt.Sprintf("connection_latency/nodes=%d/multiregion/certs", numMultiRegionNodes),
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(numMultiRegionNodes+loadNodes, spec.Geo(), spec.Zones(geoZonesStr)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runConnectionLatencyTest(ctx, t, c, numMultiRegionNodes, numZones, false /*password*/)
Expand All @@ -144,7 +144,7 @@ func registerConnectionLatencyTest(r registry.Registry) {

r.Add(registry.TestSpec{
Name: fmt.Sprintf("connection_latency/nodes=%d/multiregion/password", numMultiRegionNodes),
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(numMultiRegionNodes+loadNodes, spec.Geo(), spec.Zones(geoZonesStr)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runConnectionLatencyTest(ctx, t, c, numMultiRegionNodes, numZones, true /*password*/)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/django.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func registerDjango(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "django",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1, spec.CPU(16)),
Tags: registry.Tags(`default`, `orm`),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
7 changes: 3 additions & 4 deletions pkg/cmd/roachtest/tests/drain.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,14 @@ import (
"github.com/cockroachdb/cockroach/pkg/util/httputil"
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
"github.com/cockroachdb/errors"
"github.com/jackc/pgx/v4"
"github.com/stretchr/testify/require"
)

func registerDrain(r registry.Registry) {
{
r.Add(registry.TestSpec{
Name: "drain/early-exit-conn-wait",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runEarlyExitInConnectionWait(ctx, t, c)
Expand All @@ -47,7 +46,7 @@ func registerDrain(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "drain/warn-conn-wait-timeout",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runWarningForConnWait(ctx, t, c)
Expand All @@ -56,7 +55,7 @@ func registerDrain(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "drain/not-at-quorum",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(3),
SkipPostValidations: registry.PostValidationNoDeadNodes,
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/flowable.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func registerFlowable(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "flowable",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runFlowable(ctx, t, c)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/gopg.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func registerGopg(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "gopg",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `orm`),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/gorm.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func registerGORM(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "gorm",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `orm`),
Run: runGORM,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/hibernate.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ func registerHibernate(r registry.Registry, opt hibernateOptions) {

r.Add(registry.TestSpec{
Name: opt.testName,
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
NativeLibs: registry.LibGEOS,
Tags: registry.Tags(`default`, `orm`),
Expand Down
14 changes: 7 additions & 7 deletions pkg/cmd/roachtest/tests/import.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func registerImportNodeShutdown(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "import/nodeShutdown/worker",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(4),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
c.Put(ctx, t.Cockroach(), "./cockroach")
Expand All @@ -101,7 +101,7 @@ func registerImportNodeShutdown(r registry.Registry) {
})
r.Add(registry.TestSpec{
Name: "import/nodeShutdown/coordinator",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(4),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
c.Put(ctx, t.Cockroach(), "./cockroach")
Expand Down Expand Up @@ -164,7 +164,7 @@ func registerImportTPCC(r registry.Registry) {
timeout := 5 * time.Hour
r.Add(registry.TestSpec{
Name: testName,
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(numNodes),
Timeout: timeout,
EncryptionSupport: registry.EncryptionMetamorphic,
Expand All @@ -177,7 +177,7 @@ func registerImportTPCC(r registry.Registry) {
const geoZones = "europe-west2-b,europe-west4-b,asia-northeast1-b,us-west1-b"
r.Add(registry.TestSpec{
Name: fmt.Sprintf("import/tpcc/warehouses=%d/geo", geoWarehouses),
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(8, spec.CPU(16), spec.Geo(), spec.Zones(geoZones)),
Timeout: 5 * time.Hour,
EncryptionSupport: registry.EncryptionMetamorphic,
Expand Down Expand Up @@ -209,7 +209,7 @@ func registerImportTPCH(r registry.Registry) {
item := item
r.Add(registry.TestSpec{
Name: fmt.Sprintf(`import/tpch/nodes=%d`, item.nodes),
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(item.nodes),
Timeout: item.timeout,
EncryptionSupport: registry.EncryptionMetamorphic,
Expand Down Expand Up @@ -349,7 +349,7 @@ func runImportMixedVersion(
func registerImportMixedVersion(r registry.Registry) {
r.Add(registry.TestSpec{
Name: "import/mixed-versions",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
// Mixed-version support was added in 21.1.
Cluster: r.MakeClusterSpec(4),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down Expand Up @@ -396,7 +396,7 @@ func registerImportDecommissioned(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "import/decommissioned",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(4),
Run: runImportDecommissioned,
})
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/inverted_index.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
func registerSchemaChangeInvertedIndex(r registry.Registry) {
r.Add(registry.TestSpec{
Name: "schemachange/invertedindex",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(5),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runSchemaChangeInvertedIndex(ctx, t, c)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/jasyncsql.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func registerJasyncSQL(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "jasync",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `orm`),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/knex.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func registerKnex(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "knex",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
NativeLibs: registry.LibGEOS,
Tags: registry.Tags(`default`, `orm`),
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/libpq.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func registerLibPQ(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "lib/pq",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `driver`),
Run: runLibPQ,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/liquibase.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func registerLiquibase(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "liquibase",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `tool`),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
func registerDeclSchemaChangeCompatMixedVersions(r registry.Registry) {
r.Add(registry.TestSpec{
Name: "schemachange/mixed-versions-compat",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.IsLocal() && runtime.GOARCH == "arm64" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func registerDeclarativeSchemaChangerJobCompatibilityInMixedVersion(r registry.R
// supported in the "previous" major release.
r.Add(registry.TestSpec{
Name: "declarative_schema_changer/job-compatibility-mixed-version-V222-V231",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(4),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
if c.IsLocal() && runtime.GOARCH == "arm64" {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/mixed_version_schemachange.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
func registerSchemaChangeMixedVersions(r registry.Registry) {
r.Add(registry.TestSpec{
Name: "schemachange/mixed-versions",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
// This tests the work done for 20.1 that made schema changes jobs and in
// addition prevented making any new schema changes on a mixed cluster in
// order to prevent bugs during upgrades.
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/nodejs_postgres.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ PGSSLCERT=$HOME/certs/client.%s.crt PGSSLKEY=$HOME/certs/client.%s.key PGSSLROOT

r.Add(registry.TestSpec{
Name: "node-postgres",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `driver`),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/npgsql.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ echo '%s' | git apply --ignore-whitespace -`, npgsqlPatch),

r.Add(registry.TestSpec{
Name: "npgsql",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `driver`),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/pgjdbc.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ func registerPgjdbc(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "pgjdbc",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `driver`),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/pgx.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func registerPgx(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "pgx",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `driver`),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/pop.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func registerPop(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "pop",
Owner: registry.OwnerSQLSessions,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: registry.Tags(`default`, `orm`),
Run: runPop,
Expand Down
Loading

0 comments on commit 3280302

Please sign in to comment.