-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
80422: sql: support virtual table indexes with generators r=AlexTalks a=AlexTalks While previously virtual schema tables had support for defining tables with a `populate` function, which eagerly loads all rows, or a `generator` function, which lazy loads each row when called (possibly running in a worker Goroutine), and also had support for virtual indexes which would have their own `populate` functions, there was a subtle lack of support for using virtual indexes with virtual tables that used a `generator`, since the virtual index constraint logic would fall back to a (possibly undefined) `populate` function in several cases. This change fixes the nil pointer exception that could occur if using virtual indexes with a table using a `generator`, and validates that the virtual index is supported prior to use. Release Note: None Release Justification: Bug fix 80989: outliers: collect statement fingerprint id r=matthewtodd a=matthewtodd This change also helps set us up for #79451, where we'll be working with per-fingerprint statement latencies. Release note: None 81076: Authors: add linville to authors r=davidwding a=mdlinville Release note: None 81080: opt: calculate lookup join remaining filters more accurately r=mgartner a=mgartner #### opt: return ordinals of equality filters from memo.ExtractJoinEqualityColumns This is a prerequisite for future refactoring of `lookupjoin.ConstraintBuilder`. Release note: None #### opt: calculate lookup join remaining filters more accurately `lookupjoin.ConstraintBuilder` now determines the remaining filters for a lookup join constraint more accurately by tracking the ordinals of filters that are covered by the constraint, rather than trying to reduce the filters original filters based on the key columns, lookup expression, and constant expression. Release note: None 81089: vendor: bump panicparse r=erikgrinaker,nvanbenschoten a=tbg This picks up maruel/panicparse#74. Without this commit, the `pkg/kv/kvserver/concurrency` datadriven tests are flaky on Mac M1s since those tests rely on panicparse to parse strack traces for goroutine monitoring. Release note: None Co-authored-by: Alex Sarkesian <sarkesian@cockroachlabs.com> Co-authored-by: Matthew Todd <todd@cockroachlabs.com> Co-authored-by: Matt Linville <linville@cockroachlabs.com> Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
- Loading branch information
Showing
27 changed files
with
169 additions
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ go_library( | |
| "//pkg/sql/opt/props", | ||
| "//pkg/sql/sem/eval", | ||
| "//pkg/sql/sem/tree", | ||
| "//pkg/util", | ||
| ], | ||
| ) | ||
|
|
||
|
|
||
Oops, something went wrong.