Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/serverccl: TestTenantVars failed #119329

Open
cockroach-teamcity opened this issue Feb 17, 2024 · 4 comments
Open

ccl/serverccl: TestTenantVars failed #119329

cockroach-teamcity opened this issue Feb 17, 2024 · 4 comments
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-3 Issues/test failures with no fix SLA skipped-test T-db-server
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Feb 17, 2024 •
edited by cockroach-jira-scripts
Loading

ccl/serverccl.TestTenantVars failed on master @ 0b7ae19e2b94b851ed8812914f57032aab699811:

=== RUN   TestTenantVars
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestTenantVars411347686
    test_log_scope.go:81: use -show-logs to present logs inline
    tenant_vars_test.go:153: -- test log scope end --
test logs left over in: outputs.zip/logTestTenantVars411347686
--- FAIL: TestTenantVars (1.33s)
=== RUN   TestTenantVars/shared-process=true
    tenant_vars_test.go:143: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/serverccl/tenant_vars_test.go:143
        	            				github.com/cockroachdb/cockroach/pkg/testutils/subtest.go:28
        	Error:      	"1e+07" is not less than or equal to "0"
        	Test:       	TestTenantVars/shared-process=true
    --- FAIL: TestTenantVars/shared-process=true (0.37s)

Parameters:

  • attempt=1
  • run=4
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/multi-tenant @cockroachdb/server

This test on roachdash | Improve this report!

Jira issue: CRDB-36151
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-multitenant Issues owned by the multi-tenant virtual team labels Feb 17, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Feb 17, 2024
@cockroach-teamcity
Copy link
Member Author

ccl/serverccl.TestTenantVars failed on master @ e50b0ec4d3a53f81e26f3776ae3f3be55d435a9a:

=== RUN   TestTenantVars
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestTenantVars1514036488
    test_log_scope.go:81: use -show-logs to present logs inline
    tenant_vars_test.go:153: -- test log scope end --
test logs left over in: outputs.zip/logTestTenantVars1514036488
--- FAIL: TestTenantVars (1.33s)
=== RUN   TestTenantVars/shared-process=false
    tenant_vars_test.go:143: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/serverccl/tenant_vars_test.go:143
        	            				github.com/cockroachdb/cockroach/pkg/testutils/subtest.go:28
        	Error:      	"1e+07" is not less than or equal to "0"
        	Test:       	TestTenantVars/shared-process=false
    --- FAIL: TestTenantVars/shared-process=false (0.48s)

Parameters:

  • attempt=1
  • run=22
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@stevendanna stevendanna added P-3 Issues/test failures with no fix SLA and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 4, 2024
@msbutler
Copy link
Collaborator

this flaked on me https://teamcity.cockroachdb.com/viewLog.html?buildId=14339755&buildTypeId=Cockroach_BazelEssentialCi

@cockroach-teamcity
Copy link
Member Author

ccl/serverccl.TestTenantVars failed on master @ 34caf9d2c267f95f6aef2713708806e6f14948d6:

=== RUN   TestTenantVars
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestTenantVars3081158596
    test_log_scope.go:81: use -show-logs to present logs inline
    tenant_vars_test.go:153: -- test log scope end --
test logs left over in: outputs.zip/logTestTenantVars3081158596
--- FAIL: TestTenantVars (1.35s)
=== RUN   TestTenantVars/shared-process=true
    tenant_vars_test.go:143: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/serverccl/tenant_vars_test.go:143
        	            				github.com/cockroachdb/cockroach/pkg/testutils/subtest.go:28
        	Error:      	"1e+07" is not less than or equal to "0"
        	Test:       	TestTenantVars/shared-process=true
    --- FAIL: TestTenantVars/shared-process=true (0.36s)

Parameters:

  • =true
  • attempt=1
  • run=26
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@stevendanna stevendanna mentioned this issue Mar 16, 2024
Merged
@cockroach-teamcity
Copy link
Member Author

ccl/serverccl.TestTenantVars failed on master @ f0116ea373a2b87155e7f0264df4f783ce177360:

=== RUN   TestTenantVars
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestTenantVars1251763533
    test_log_scope.go:81: use -show-logs to present logs inline
    tenant_vars_test.go:153: -- test log scope end --
test logs left over in: outputs.zip/logTestTenantVars1251763533
--- FAIL: TestTenantVars (1.39s)
=== RUN   TestTenantVars/shared-process=true
    tenant_vars_test.go:143: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/serverccl/tenant_vars_test.go:143
        	            				github.com/cockroachdb/cockroach/pkg/testutils/subtest.go:28
        	Error:      	"1e+07" is not less than or equal to "0"
        	Test:       	TestTenantVars/shared-process=true
    --- FAIL: TestTenantVars/shared-process=true (0.44s)

Parameters:

  • attempt=1
  • run=24
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

stevendanna added a commit to stevendanna/cockroach that referenced this issue Mar 20, 2024
@stevendanna
ccl/serverccl: skip flakey assertion
d169e77 
Informs cockroachdb#119329
Release note: None
craig bot pushed a commit that referenced this issue Mar 20, 2024
@itsbilal @xinhaoz
@stevendanna @DrewKimball @renatolabs
Merge #120023 #120430 #120594 #120686 #120760
aa2e1fb 
120023: roachtest: add run-operation command to run singular operation  r=HerkoLategan a=itsbilal

NB: This change builds on #119796. Review that first.

This change adds a new roachtest command, run-operation,
that runs a singular operation defined in OperationSpec
(see #119796), in a simplified harness, with existing
clusters only. The existing cluster is not touched (eg.
stopped or wiped), unless the operation explicitly
does an action like that.

An implementation of operation.Operation is also bundled in this
change to make these operations runnable.

Epic: none

Release note: None

120430: sql/sem/tree: add FmtForFingerprint functions to collapse long lists  r=xinhaoz a=xinhaoz

Please note only the latest commit should be reviewed here.

---------------
Add functions for the `FmtForFingerprint` flag to shorten long lists
to a representative two element list where the second element is simply
`__more__` to represent the rest of the list.

Specifically, where `FmtHideConstants` would shorten tuples, arrays and
VALUES clauses to its first two elements if it coontains only literals
and placeholders, `FmtCollapseLists` shortens these lists to its first
element if all items in the list are any combination of placeholders,
literals, or a simple subexpressions containing only literals and/or
placeholders.

Enabling this behaviour for statement fingerprint generation can be done
via setting the cluster setting `sql.stats.statement_fingerprint.format_mask`
to include `FmtCollapseLists`.

```
FmtHideConstants (previous behaviour):
VALUES ((1, 2), (3, 4)), ((5, 6), (7, 8)), ((9, 10), (11, 12)) ->
VALUES ((_, _), (_, _)), ((_, _), (_, _)), ((_, _), (_, _))

ARRAY[1, 2, 3+4] ->
ARRAY[_, _, _+4]

SELECT * FROM foo WHERE a IN (1, 2, 3, 4, 5) ->
SELECT * FROM foo WHERE a IN (1, 2, __more1_10__)

---

FmtHideConstants | FmtCollapseLists:
VALUES ((1, 2), (3, 4)), ((5, 6), (7, 8)), ((9, 10), (11, 12)) ->
VALUES ((_, __more__), __more__), (__more__)

ARRAY[1, 2, 3+4] ->
ARRAY[_, __more__]

SELECT * FROM foo WHERE a IN (1, 2, 3, 4, 5) ->
SELECT * FROM foo WHERE a IN (1, __more__)
```


Epic: none
Part of: #120409
Release note: none

120594: ccl/serverccl: skip flakey assertion r=msbutler a=stevendanna

Informs #119329
Release note: None

120686: plpgsql: implement CONTINUE/EXIT with condition r=DrewKimball a=DrewKimball

PL/pgSQL allows adding a `WHEN <condition>` clause to `EXIT` and `CONTINUE` statements. This is syntactic sugar for `EXIT` or `CONTINUE` within an `IF` statement. This commit add support for this syntax.

Informs #115271

Release note (sql change): It is now possible to specify a condition for the PL/pgSQL statemenets `EXIT` and `CONTINUE`.

120760: roachprod: remove `admin-ui-port` flag from `start-sql` r=DarrylWong a=renatolabs

This flag is only applicable to the system tenant (`roachprod start`); having it on `start-sql` is misleading.

Epic: none

Release note: None

Co-authored-by: Bilal Akhtar <bilal@cockroachlabs.com>
Co-authored-by: Xin Hao Zhang <xzhang@cockroachlabs.com>
Co-authored-by: Steven Danna <danna@cockroachlabs.com>
Co-authored-by: Drew Kimball <drewk@cockroachlabs.com>
Co-authored-by: Renato Costa <renato@cockroachlabs.com>
@cockroach-teamcity cockroach-teamcity mentioned this issue May 12, 2024
Closed
@stevendanna stevendanna removed their assignment Jun 11, 2024
@stevendanna stevendanna added T-db-server skipped-test and removed T-multitenant Issues owned by the multi-tenant virtual team labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-3 Issues/test failures with no fix SLA skipped-test T-db-server
Projects
None yet
Milestone
24.1
Development

No branches or pull requests
3 participants
@stevendanna @cockroach-teamcity @msbutler