opt: stack overflow caused by RejectNullsUnderJoinLeft #64661
Comments
RaduBerinde
added
the
C-bug
|
The loop would be explained if we pushed down an |
|
@RaduBerinde do you have a query to reproduce this? |
I'm gonna kindly beat my drum re: query dumps from crash time: #52815 (This issue happened in CC prod.) |
That would be too easy :) |
|
Actually, what is required for this loop is that we push down an |
|
A cycle in the memo could cause this, so I thought it could be related to #58437, but that landed in v20.2.4. It could still be a cycle in the memo, but I'm not sure whether this would be the first function that would recurse forever — there would be many recursive functions that would if there was a cycle. |
|
The stack clearly indicates repeated application of |
|
Oops, I misunderstood your previous comment and incorrectly read it as repeated calls to |
RaduBerinde
added
the
S-2-temp-unavailability
|
I've been staring at this code for the better part of the day. The only thing that I could find that is problematic is |
64662: storage/cloud: delegate redaction and implicit auth checks r=dt a=dt storage/cloud: make implicit auth check funciton of conf Previously we had two methods that dug through ExternalStorage URI params: One, which extracted the params to create a structured config that would actually be used to open and interact with that storage, and a second that looked for authorization-releated params to decide if access was explicitly or implicitly authorized (i.e. had credentials specified, or made use of the access the node performing the action had). This changes the latter to instead be a function of the former, so there is only one method that extracts parameters from string URIs to produce a structured configuration object, and then the determination of if a given configuration is one that carries explicit authorization can be done from that config object. storage/cloud: make implementations register redaction params This changes the redaction of URIs from being done from a pre-defined map of sensitive params to a runtime populated map, in which implementations register their sensitive params during their registration during init. Release note: none. 64695: deps: update golang.org/x/text to 0.3.6 r=knz a=rafiss fixes #63559 Release note (sql change): Collated strings may now have a locale that is a language tag, followed by a `-u-` suffix, followed by anything else. For example, any locale with a prefix of `en-US-u-` is now considered valid. 64698: opt: fix null reject rule cycle r=RaduBerinde a=RaduBerinde Fixing a corner case where we are requesting null rejection on a non-null Scan column. This causes a stack overflow. We also add an assertion that would have caught this (and returned an internal error instead of crashing the node). Fixes #64661. Release note (bug fix): fixed a stack overflow that can happen in some cornercases involving partial indexes with predicates containing `(x IS NOT NULL)`. 64718: geos/BUILD.bzl: missing `-lm` r=rickystewart,rail a=knz Fixes #64713. The math functions are not included in libc in BSD. Release note: None Co-authored-by: David Taylor <tinystatemachine@gmail.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Fixing a corner case where we are requesting null rejection on a non-null Scan column. This causes a stack overflow. We also add an assertion that would have caught this (and returned an internal error instead of crashing the node). Fixes cockroachdb#64661. Release note (bug fix): fixed a stack overflow that can happen in some cornercases involving partial indexes with predicates containing `(x IS NOT NULL)`.
Fixing a corner case where we are requesting null rejection on a non-null Scan column. This causes a stack overflow. We also add an assertion that would have caught this (and returned an internal error instead of crashing the node). Fixes #64661. Release note (bug fix): fixed a stack overflow that can happen in some cornercases involving partial indexes with predicates containing `(x IS NOT NULL)`.
Fixing a corner case where we are requesting null rejection on a non-null Scan column. This causes a stack overflow. We also add an assertion that would have caught this (and returned an internal error instead of crashing the node). Fixes cockroachdb#64661. Release note (bug fix): fixed a stack overflow that can happen in some cornercases involving partial indexes with predicates containing `(x IS NOT NULL)`.
On v20.2.6:
factory.og.go:2912 is RejectNullsUnderJoinLeft.
The text was updated successfully, but these errors were encountered: