Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roachprod: adding unit test and renaming ssh.go #65928

Closed
alan-mas opened this issue Jun 1, 2021 · 1 comment · Fixed by #64156
Closed

Roachprod: adding unit test and renaming ssh.go #65928

alan-mas opened this issue Jun 1, 2021 · 1 comment · Fixed by #64156
Assignees
Labels
O-community Originated from the community T-dev-inf X-blathers-untriaged blathers was unable to find an owner

Comments

@alan-mas
Copy link
Contributor

alan-mas commented Jun 1, 2021

We need to refactor ssh.go (as one type structure is in use, we cannot remove it completely).

So we are refactoring ssh.go and change its name to io.go and only keeping ProgressWriter struct and function.
Also we are adding some unit testing for this new go file.

@blathers-crl
Copy link

blathers-crl bot commented Jun 1, 2021

Hello, I am Blathers. I am here to help you get the issue triaged.

It looks like you have not filled out the issue in the format of any of our templates. To best assist you, we advise you to use one of these templates.

I was unable to automatically find someone to ping.

If we have not gotten back to your issue within a few business days, you can try the following:

  • Join our community slack channel and ask on #cockroachdb.
  • Try find someone from here if you know they worked closely on the area and CC them.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels Jun 1, 2021
@alan-mas alan-mas self-assigned this Jun 1, 2021
@craig craig bot closed this as completed in f8956ee Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community T-dev-inf X-blathers-untriaged blathers was unable to find an owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants