roachprod: adding unit test and renaming ssh.go

[alan-mas]

Third part of #47567 and fixes #65928 where we need to refactor ssh.go (as one type structure is in use, we cannot remove it completely).

So we are refactoring ssh.go and change its name to io.go and only keeping ProgressWriter struct and function.
Also we are adding some unit testing for this new go file.

Release note: None

[blathers-crl]

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[cockroach-teamcity]

This change is 

[blathers-crl]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[CLAassistant]

All committers have signed the CLA.

[jlinder]

Reviewed 4 of 4 files at r1.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @alan-mas)

[jlinder]

Reviewed 2 of 2 files at r4.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @alan-mas)

---

pkg/cmd/roachprod/ssh/io_test.go, line 54 at r4 (raw file):

Quoted 5 lines of code…

	defer func() {
		if err := os.Remove(output.Name()); err != nil {
			t.Fatal(err)
		}
	}()

Please put this right under the defer output.Close() near the beginning of this function.

[jlinder]

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @alan-mas and @jlinder)

---

pkg/cmd/roachprod/ssh/io_test.go, line 25 at r5 (raw file):

		t.Fatal(err)
	}
	fmt.Println(output.Name())

Why output the name of the file?

[alan-mas]

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @jlinder)

---

pkg/cmd/roachprod/ssh/io_test.go, line 54 at r4 (raw file):

Previously, jlinder (James H. Linder) wrote…

	defer func() {
		if err := os.Remove(output.Name()); err != nil {
			t.Fatal(err)
		}
	}()

Please put this right under the defer output.Close() near the beginning of this function.

Done

---

pkg/cmd/roachprod/ssh/io_test.go, line 25 at r5 (raw file):

Previously, jlinder (James H. Linder) wrote…

Why output the name of the file?

Sorry for that I was printing the name to ensure the code was actually removing (so after running the test I can try to cat to file) and forgot to removing it. Just did it now.

[jlinder]

Reviewed 1 of 1 files at r7.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @alan-mas)

[jlinder]

bors r+

[craig]

👎 Rejected by label

[jlinder]

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)