Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reports: generate reports without relying on gossiped system config #74665

Closed
ajwerner opened this issue Jan 11, 2022 · 0 comments
Closed

reports: generate reports without relying on gossiped system config #74665

ajwerner opened this issue Jan 11, 2022 · 0 comments
Assignees
Labels
A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@ajwerner
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We currently generate reports on the system tenant in terms of sql concepts known to the zone-config layer. The KV layer learns about these updates via gossip today. We'd like to stop gossiping this data (#70560).

Describe the solution you'd like
Use a rangefeed-backed cache of the relevant system config data. See #70557 (comment).

Describe alternatives you've considered

Another approach would be to leverage span configs and augment the span configs with the relevant IDs needed for the reports. That has the benefit of being more space efficient. It doesn't necessarily extend back out to generating the reports in secondary tenants as well, though it's not clear we want that.

Additional context

Eventually we might want to generate such reports in secondary tenants (#70557). This is far from certain. If we did want that, we could leverage the approach here (for better or for worse), move the generation to a job, and run it in a sql pod.

Epic: CRDB-10489

@ajwerner ajwerner added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-zone-configs labels Jan 11, 2022
@ajwerner ajwerner self-assigned this Jan 11, 2022
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Jan 11, 2022
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-schema-deprecated Use T-sql-foundations instead label Jan 11, 2022
@ajwerner ajwerner self-assigned this Jan 11, 2022
@exalate-issue-sync exalate-issue-sync bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Jan 11, 2022
ajwerner added a commit to ajwerner/cockroach that referenced this issue Jan 13, 2022
This also adopts the rangefeed backed cache for the optimizer and for
the reporter.

Fixes cockroachdb#70558
Fixes cockroachdb#74665

Release note: None
ajwerner added a commit to ajwerner/cockroach that referenced this issue Jan 31, 2022
This also adopts the rangefeed backed cache for the optimizer and for
the reporter.

Fixes cockroachdb#70558
Fixes cockroachdb#74665

Release note: None
@craig craig bot closed this as completed in 9d9e975 Feb 2, 2022
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-schema-deprecated Use T-sql-foundations instead label May 10, 2023
@exalate-issue-sync exalate-issue-sync bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-zone-configs C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

1 participant