copy: fix extra flush loop causing test to flake #101792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
DrewKimball
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
cucaroach
added
backport-23.1.x
|
bors r+ |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
cucaroach
force-pushed
the
fix-cpy-flushing
branch
from
79d8f1a
to
bfa5f72
Compare
|
bors retry |
|
Build failed: |
|
bors retry |
|
Build failed: |
cucaroach
force-pushed
the
fix-cpy-flushing
branch
from
bfa5f72
to
cd85d48
Compare
Previously we would try again and increment batch number when a retriable error occurred, now we call a hook on retries so we can uncount that batch. Also don't bother calling the insert routine if the length of the batch is 0, it will be a noop but still call the hook incrementing the batch counter. Release note: None Epic: None Fixes: cockroachdb#101610
cucaroach
force-pushed
the
fix-cpy-flushing
branch
from
cd85d48
to
1ccc551
Compare
|
bors retry |
|
Build succeeded: |
This was referenced May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None
Epic: None
Fixes: #101610