Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeowners, roachtest: merge SQL schema + sessions to SQL foundations #103536

Merged
merged 1 commit into from
May 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 47 additions & 47 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -38,45 +38,45 @@
/pkg/sql/show_create*.go @cockroachdb/sql-syntax-prs
/pkg/sql/types/ @cockroachdb/sql-syntax-prs

/pkg/sql/crdb_internal.go @cockroachdb/sql-sessions
/pkg/sql/pg_catalog.go @cockroachdb/sql-sessions
/pkg/sql/pgwire/ @cockroachdb/sql-sessions
/pkg/sql/sem/builtins/ @cockroachdb/sql-sessions
/pkg/sql/vtable/ @cockroachdb/sql-sessions
/pkg/sql/crdb_internal.go @cockroachdb/sql-foundations
/pkg/sql/pg_catalog.go @cockroachdb/sql-foundations
/pkg/sql/pgwire/ @cockroachdb/sql-foundations
/pkg/sql/sem/builtins/ @cockroachdb/sql-foundations
/pkg/sql/vtable/ @cockroachdb/sql-foundations

/pkg/sql/sessiondata/ @cockroachdb/sql-sessions
/pkg/sql/tests/rsg_test.go @cockroachdb/sql-sessions
/pkg/sql/ttl @cockroachdb/sql-sessions
/pkg/sql/sessiondata/ @cockroachdb/sql-foundations
/pkg/sql/tests/rsg_test.go @cockroachdb/sql-foundations
/pkg/sql/ttl @cockroachdb/sql-foundations

/pkg/ccl/schemachangerccl/ @cockroachdb/sql-schema
/pkg/sql/catalog/ @cockroachdb/sql-schema
/pkg/ccl/schemachangerccl/ @cockroachdb/sql-foundations
/pkg/sql/catalog/ @cockroachdb/sql-foundations
/pkg/sql/catalog/multiregion @cockroachdb/multiregion
/pkg/sql/doctor/ @cockroachdb/sql-schema
/pkg/sql/gcjob/ @cockroachdb/sql-schema
/pkg/sql/gcjob_test/ @cockroachdb/sql-schema
/pkg/sql/privilege/ @cockroachdb/sql-schema
/pkg/sql/schemachange/ @cockroachdb/sql-schema
/pkg/sql/schemachanger/ @cockroachdb/sql-schema
/pkg/sql/alter*.go @cockroachdb/sql-schema
/pkg/sql/backfill*.go @cockroachdb/sql-schema
/pkg/sql/create*.go @cockroachdb/sql-schema
/pkg/sql/database*.go @cockroachdb/sql-schema
/pkg/sql/drop*.go @cockroachdb/sql-schema
/pkg/sql/grant*.go @cockroachdb/sql-schema
/pkg/sql/rename*.go @cockroachdb/sql-schema
/pkg/sql/revoke*.go @cockroachdb/sql-schema
/pkg/sql/schema*.go @cockroachdb/sql-schema
/pkg/sql/zone*.go @cockroachdb/sql-schema
/pkg/sql/doctor/ @cockroachdb/sql-foundations
/pkg/sql/gcjob/ @cockroachdb/sql-foundations
/pkg/sql/gcjob_test/ @cockroachdb/sql-foundations
/pkg/sql/privilege/ @cockroachdb/sql-foundations
/pkg/sql/schemachange/ @cockroachdb/sql-foundations
/pkg/sql/schemachanger/ @cockroachdb/sql-foundations
/pkg/sql/alter*.go @cockroachdb/sql-foundations
/pkg/sql/backfill*.go @cockroachdb/sql-foundations
/pkg/sql/create*.go @cockroachdb/sql-foundations
/pkg/sql/database*.go @cockroachdb/sql-foundations
/pkg/sql/drop*.go @cockroachdb/sql-foundations
/pkg/sql/grant*.go @cockroachdb/sql-foundations
/pkg/sql/rename*.go @cockroachdb/sql-foundations
/pkg/sql/revoke*.go @cockroachdb/sql-foundations
/pkg/sql/schema*.go @cockroachdb/sql-foundations
/pkg/sql/zone*.go @cockroachdb/sql-foundations

/pkg/cli/ @cockroachdb/cli-prs
# last-rule-wins so bulk i/o takes userfile.go even though cli-prs takes pkg/cli
/pkg/cli/userfile.go @cockroachdb/disaster-recovery
/pkg/cli/demo*.go @cockroachdb/cli-prs @cockroachdb/sql-sessions @cockroachdb/server-prs
/pkg/cli/demo*.go @cockroachdb/cli-prs @cockroachdb/sql-foundations @cockroachdb/server-prs
/pkg/cli/debug*.go @cockroachdb/cli-prs @cockroachdb/kv-prs
/pkg/cli/debug_job_trace*.go @cockroachdb/disaster-recovery
/pkg/cli/doctor*.go @cockroachdb/cli-prs @cockroachdb/sql-schema
/pkg/cli/doctor*.go @cockroachdb/cli-prs @cockroachdb/sql-foundations
/pkg/cli/import_test.go @cockroachdb/cli-prs @cockroachdb/disaster-recovery
/pkg/cli/sql*.go @cockroachdb/cli-prs @cockroachdb/sql-sessions
/pkg/cli/sql*.go @cockroachdb/cli-prs @cockroachdb/sql-foundations
/pkg/cli/start*.go @cockroachdb/cli-prs @cockroachdb/server-prs
/pkg/cli/mt_proxy.go @cockroachdb/sqlproxy-prs @cockroachdb/server-prs
/pkg/cli/mt_start_sql.go @cockroachdb/sqlproxy-prs @cockroachdb/server-prs
Expand Down Expand Up @@ -120,10 +120,10 @@

/pkg/gen/ @cockroachdb/dev-inf

/pkg/acceptance/ @cockroachdb/sql-sessions
/pkg/acceptance/ @cockroachdb/sql-foundations
/pkg/base/ @cockroachdb/server-prs
/pkg/bench/ @cockroachdb/sql-queries-noreview
/pkg/bench/rttanalysis @cockroachdb/sql-schema
/pkg/bench/rttanalysis @cockroachdb/sql-foundations
/pkg/blobs/ @cockroachdb/disaster-recovery
/pkg/build/ @cockroachdb/dev-inf
/pkg/ccl/baseccl/ @cockroachdb/cli-prs
Expand All @@ -138,35 +138,35 @@
/pkg/ccl/multiregionccl/ @cockroachdb/multiregion
/pkg/ccl/multitenantccl/ @cockroachdb/unowned
/pkg/ccl/oidcccl/ @cockroachdb/server-prs
/pkg/ccl/partitionccl/ @cockroachdb/sql-schema @cockroachdb/multiregion
/pkg/ccl/partitionccl/ @cockroachdb/sql-foundations @cockroachdb/multiregion
/pkg/ccl/serverccl/ @cockroachdb/server-prs
/pkg/ccl/serverccl/statusccl @cockroachdb/sql-observability
/pkg/ccl/telemetryccl/ @cockroachdb/obs-inf-prs
/pkg/ccl/testccl/sqlccl/ @cockroachdb/sql-queries
/pkg/ccl/testccl/workload/schemachange/ @cockroachdb/sql-schema
/pkg/ccl/testccl/workload/schemachange/ @cockroachdb/sql-foundations
/pkg/ccl/testutilsccl/ @cockroachdb/test-eng-noreview
/pkg/ccl/utilccl/ @cockroachdb/server-prs
/pkg/ccl/workloadccl/ @cockroachdb/sql-sessions-noreview
/pkg/ccl/benchccl/rttanalysisccl/ @cockroachdb/sql-schema
/pkg/ccl/workloadccl/ @cockroachdb/sql-foundations-noreview
/pkg/ccl/benchccl/rttanalysisccl/ @cockroachdb/sql-foundations
/pkg/clusterversion/ @cockroachdb/kv-prs-noreview
/pkg/cmd/allocsim/ @cockroachdb/kv-prs
/pkg/cmd/bazci/ @cockroachdb/dev-inf
/pkg/cmd/cmdutil/ @cockroachdb/dev-inf
/pkg/cmd/cmp-protocol/ @cockroachdb/sql-sessions
/pkg/cmd/cmp-sql/ @cockroachdb/sql-sessions
/pkg/cmd/cmpconn/ @cockroachdb/sql-sessions
/pkg/cmd/cmp-protocol/ @cockroachdb/sql-foundations
/pkg/cmd/cmp-sql/ @cockroachdb/sql-foundations
/pkg/cmd/cmpconn/ @cockroachdb/sql-foundations
/pkg/cmd/cockroach/ @cockroachdb/cli-prs
/pkg/cmd/cockroach-oss/ @cockroachdb/cli-prs
/pkg/cmd/cockroach-short/ @cockroachdb/cli-prs
/pkg/cmd/compile-build/ @cockroachdb/dev-inf
/pkg/cmd/cr2pg/ @cockroachdb/sql-sessions
/pkg/cmd/cr2pg/ @cockroachdb/sql-foundations
/pkg/cmd/dev/ @cockroachdb/dev-inf
/pkg/cmd/docgen/ @cockroachdb/docs
/pkg/cmd/docs-issue-generation/ @cockroachdb/dev-inf
/pkg/cmd/fuzz/ @cockroachdb/test-eng
/pkg/cmd/generate-binary/ @cockroachdb/sql-sessions
/pkg/cmd/generate-binary/ @cockroachdb/sql-foundations
/pkg/cmd/generate-distdir/ @cockroachdb/dev-inf
/pkg/cmd/generate-metadata-tables/ @cockroachdb/sql-sessions
/pkg/cmd/generate-metadata-tables/ @cockroachdb/sql-foundations
/pkg/cmd/generate-spatial-ref-sys/ @cockroachdb/geospatial
/pkg/cmd/generate-test-suites/ @cockroachdb/dev-inf
/pkg/cmd/generate-staticcheck/ @cockroachdb/dev-inf
Expand Down Expand Up @@ -196,7 +196,7 @@
/pkg/cmd/roachtest/tests @cockroachdb/test-eng-noreview
/pkg/cmd/roachvet/ @cockroachdb/dev-inf
/pkg/cmd/skip-test/ @cockroachdb/test-eng
/pkg/cmd/skiperrs/ @cockroachdb/sql-sessions
/pkg/cmd/skiperrs/ @cockroachdb/sql-foundations
/pkg/cmd/skipped-tests/ @cockroachdb/test-eng
/pkg/cmd/smithcmp/ @cockroachdb/sql-queries
/pkg/cmd/smithtest/ @cockroachdb/sql-queries
Expand All @@ -205,11 +205,11 @@
/pkg/cmd/uptodate/ @cockroachdb/dev-inf
/pkg/cmd/urlcheck/ @cockroachdb/docs
/pkg/cmd/whoownsit/ @cockroachdb/test-eng
/pkg/cmd/workload/ @cockroachdb/sql-sessions-noreview
/pkg/cmd/workload/ @cockroachdb/sql-foundations-noreview
/pkg/cmd/wraprules/ @cockroachdb/obs-inf-prs-noreview
/pkg/cmd/zerosum/ @cockroachdb/kv-noreview
/pkg/col/ @cockroachdb/sql-queries
/pkg/compose/ @cockroachdb/sql-sessions
/pkg/compose/ @cockroachdb/sql-foundations
/pkg/config/ @cockroachdb/server-prs
/pkg/docs/ @cockroachdb/docs
/pkg/featureflag/ @cockroachdb/cli-prs-noreview
Expand All @@ -225,7 +225,7 @@
/pkg/keysbase/ @cockroachdb/kv-prs
# Don't ping KV on updates to reserved descriptor IDs and such.
/pkg/keys/constants.go @cockroachdb/kv-prs-noreview
/pkg/migration/ @cockroachdb/kv-prs-noreview @cockroachdb/sql-schema
/pkg/migration/ @cockroachdb/kv-prs-noreview @cockroachdb/sql-foundations
/pkg/multitenant @cockroachdb/unowned
/pkg/release/ @cockroachdb/dev-inf
/pkg/roachpb/.gitattributes @cockroachdb/dev-inf
Expand Down Expand Up @@ -260,7 +260,7 @@
/pkg/security/ @cockroachdb/server-prs @cockroachdb/prodsec
/pkg/settings/ @cockroachdb/server-prs
/pkg/spanconfig/ @cockroachdb/kv-prs
/pkg/startupmigrations/ @cockroachdb/server-prs @cockroachdb/sql-schema
/pkg/startupmigrations/ @cockroachdb/server-prs @cockroachdb/sql-foundations
/pkg/streaming/ @cockroachdb/disaster-recovery
/pkg/testutils/ @cockroachdb/test-eng-noreview
/pkg/testutils/reduce/ @cockroachdb/sql-queries
Expand All @@ -272,7 +272,7 @@
/pkg/util/metric @cockroachdb/obs-inf-prs
/pkg/util/stop @cockroachdb/server-prs
/pkg/util/tracing @cockroachdb/obs-inf-prs
/pkg/workload/ @cockroachdb/sql-sessions-noreview
/pkg/workload/ @cockroachdb/sql-foundations-noreview

# Allow the security team to have insight into changes to
# authn/authz code.
Expand Down
8 changes: 3 additions & 5 deletions TEAMS.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,13 @@

cockroachdb/docs:
triage_column_id: 3971225
cockroachdb/sql-sessions:
cockroachdb/sql-foundations:
aliases:
cockroachdb/sql-syntax-prs: other
cockroachdb/sqlproxy-prs: other
cockroachdb/sql-api-prs: other
triage_column_id: 7259065
label: T-sql-sessions
cockroachdb/sql-schema:
triage_column_id: 8946818
triage_column_id: 19467489
label: T-sql-foundations
cockroachdb/sql-queries:
aliases:
cockroachdb/sql-optimizer: other
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/roachtest/registry/owners.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type Owner string

// The allowable values of Owner.
const (
OwnerSQLExperience Owner = `sql-sessions`
OwnerSQLFoundations Owner = `sql-foundations`
OwnerDisasterRecovery Owner = `disaster-recovery`
OwnerCDC Owner = `cdc`
OwnerKV Owner = `kv`
Expand All @@ -25,7 +25,6 @@ const (
OwnerObsInf Owner = `obs-inf-prs`
OwnerServer Owner = `server`
OwnerSQLQueries Owner = `sql-queries`
OwnerSQLSchema Owner = `sql-schema`
OwnerStorage Owner = `storage`
OwnerTestEng Owner = `test-eng`
OwnerDevInf Owner = `dev-inf`
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/activerecord.go
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ func registerActiveRecord(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "activerecord",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: []string{`default`, `orm`},
Run: runActiveRecord,
Expand Down
6 changes: 3 additions & 3 deletions pkg/cmd/roachtest/tests/alterpk.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,15 +172,15 @@ func registerAlterPK(r registry.Registry) {
}
r.Add(registry.TestSpec{
Name: "alterpk-bank",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
// Use a 4 node cluster -- 3 nodes will run cockroach, and the last will be the
// workload driver node.
Cluster: r.MakeClusterSpec(4),
Run: runAlterPKBank,
})
r.Add(registry.TestSpec{
Name: "alterpk-tpcc-250",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
// Use a 4 node cluster -- 3 nodes will run cockroach, and the last will be the
// workload driver node.
Cluster: r.MakeClusterSpec(4, spec.CPU(32)),
Expand All @@ -190,7 +190,7 @@ func registerAlterPK(r registry.Registry) {
})
r.Add(registry.TestSpec{
Name: "alterpk-tpcc-500",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
// Use a 4 node cluster -- 3 nodes will run cockroach, and the last will be the
// workload driver node.
Cluster: r.MakeClusterSpec(4, spec.CPU(16)),
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/asyncpg.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func registerAsyncpg(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "asyncpg",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1, spec.CPU(16)),
Tags: []string{`default`, `orm`},
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
6 changes: 3 additions & 3 deletions pkg/cmd/roachtest/tests/connection_latency.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func registerConnectionLatencyTest(r registry.Registry) {
numNodes := 3
r.Add(registry.TestSpec{
Name: fmt.Sprintf("connection_latency/nodes=%d/certs", numNodes),
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
// Add one more node for load node.
Cluster: r.MakeClusterSpec(numNodes+1, spec.Zones(regionUsCentral)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand All @@ -134,7 +134,7 @@ func registerConnectionLatencyTest(r registry.Registry) {

r.Add(registry.TestSpec{
Name: fmt.Sprintf("connection_latency/nodes=%d/multiregion/certs", numMultiRegionNodes),
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(numMultiRegionNodes+loadNodes, spec.Geo(), spec.Zones(geoZonesStr)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runConnectionLatencyTest(ctx, t, c, numMultiRegionNodes, numZones, false /*password*/)
Expand All @@ -143,7 +143,7 @@ func registerConnectionLatencyTest(r registry.Registry) {

r.Add(registry.TestSpec{
Name: fmt.Sprintf("connection_latency/nodes=%d/multiregion/password", numMultiRegionNodes),
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(numMultiRegionNodes+loadNodes, spec.Geo(), spec.Zones(geoZonesStr)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runConnectionLatencyTest(ctx, t, c, numMultiRegionNodes, numZones, true /*password*/)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/django.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ func registerDjango(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "django",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1, spec.CPU(16)),
Tags: []string{`default`, `orm`},
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
6 changes: 3 additions & 3 deletions pkg/cmd/roachtest/tests/drain.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func registerDrain(r registry.Registry) {
{
r.Add(registry.TestSpec{
Name: "drain/early-exit-conn-wait",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runEarlyExitInConnectionWait(ctx, t, c)
Expand All @@ -47,7 +47,7 @@ func registerDrain(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "drain/warn-conn-wait-timeout",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runWarningForConnWait(ctx, t, c)
Expand All @@ -56,7 +56,7 @@ func registerDrain(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "drain/not-at-quorum",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(3),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runClusterNotAtQuorum(ctx, t, c)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/flowable.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func registerFlowable(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "flowable",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runFlowable(ctx, t, c)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/gopg.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func registerGopg(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "gopg",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: []string{`default`, `orm`},
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/gorm.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func registerGORM(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "gorm",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: []string{`default`, `orm`},
Run: runGORM,
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/hibernate.go
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ func registerHibernate(r registry.Registry, opt hibernateOptions) {

r.Add(registry.TestSpec{
Name: opt.testName,
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: []string{`default`, `orm`},
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/inverted_index.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
func registerSchemaChangeInvertedIndex(r registry.Registry) {
r.Add(registry.TestSpec{
Name: "schemachange/invertedindex",
Owner: registry.OwnerSQLSchema,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(5),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runSchemaChangeInvertedIndex(ctx, t, c)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/jasyncsql.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ func registerJasyncSQL(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "jasync",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: []string{`default`, `orm`},
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/knex.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func registerKnex(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "knex",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: []string{`default`, `orm`},
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/libpq.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func registerLibPQ(r registry.Registry) {

r.Add(registry.TestSpec{
Name: "lib/pq",
Owner: registry.OwnerSQLExperience,
Owner: registry.OwnerSQLFoundations,
Cluster: r.MakeClusterSpec(1),
Tags: []string{`default`, `driver`},
Run: runLibPQ,
Expand Down
Loading