Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base: enable Raft CheckQuorum by default #104042

Merged
merged 1 commit into from
Jun 28, 2023
Merged

base: enable Raft CheckQuorum by default #104042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions pkg/base/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,14 +266,8 @@ var (
// etcd/raft does register MsgHeartbeatResp as follower activity, and these
// are sent across the low-latency system RPC class, so it shouldn't be
// affected by RPC head-of-line blocking for MsgApp traffic.
//
// Note that time will not appear to progress on a quiesced range, so when
// unquiescing it may take some time before a leader steps down or a candidate
// is able to obtain prevotes.
//
// For now, we disable this by default, due to liveness concerns.
defaultRaftEnableCheckQuorum = envutil.EnvOrDefaultBool(
"COCKROACH_RAFT_ENABLE_CHECKQUORUM", false)
"COCKROACH_RAFT_ENABLE_CHECKQUORUM", true)

// defaultRaftLogTruncationThreshold specifies the upper bound that a single
// Range's Raft log can grow to before log truncations are triggered while at
Expand Down
2 changes: 1 addition & 1 deletion pkg/base/testdata/raft_config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ echo
RaftHeartbeatIntervalTicks: (int) 2,
RangeLeaseDuration: (time.Duration) 6s,
RangeLeaseRenewalFraction: (float64) 0.5,
RaftEnableCheckQuorum: (bool) false,
RaftEnableCheckQuorum: (bool) true,
RaftLogTruncationThreshold: (int64) 16777216,
RaftProposalQuota: (int64) 8388608,
RaftMaxUncommittedEntriesSize: (uint64) 16777216,
Expand Down