Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: deflake all tests that restart test cluster servers #106145

Merged
merged 15 commits into from
Jul 13, 2023
Merged

kvserver: deflake all tests that restart test cluster servers #106145

merged 15 commits into from
Jul 13, 2023

Commits on Jul 12, 2023

  1. testutils: move ListenerRegistry to leaf package 

    We'll want to access it from `base`, which can't import `testutils` due to
dependency cycles.
    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    5f4496b View commit details
    Browse the repository at this point in the history

  2. listenerutil: export ReusableListener 

    We'll type assert on it in future commits.
    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    70dce12 View commit details
    Browse the repository at this point in the history

  3. listenerutil: code movement 

    Future commits will change the receiver to ReusableListener.
    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d1c7fcd View commit details
    Browse the repository at this point in the history

  4. listenerutil: return ReusableListener from GetOrFail

    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    788decf View commit details
    Browse the repository at this point in the history

  5. listenerutil: put registry into ReusableListener

    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    98744d3 View commit details
    Browse the repository at this point in the history

  6. listenerutil: add ListenerRegistry.MustGet 

    We'll clean up the possible confusion with `GetOrFail` (which will create the listener if not present) later.
    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d21226d View commit details
    Browse the repository at this point in the history

  7. listenerutil: rename GetOrFail to MustGetOrCreate

    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8a54f4d View commit details
    Browse the repository at this point in the history

  8. listenerutil: move Reopen to ReusableListener

    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9332af7 View commit details
    Browse the repository at this point in the history

  9. listenerutil: use require.TestingT instead of *testing.T

    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c2e4b69 View commit details
    Browse the repository at this point in the history

  10. listenerutil: return pointer from NewListenerRegistry

    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    759e606 View commit details
    Browse the repository at this point in the history

  11. listenerutil: add a unit test

    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    5320237 View commit details
    Browse the repository at this point in the history

  12. testcluster: introduce ReusableListenerReg 

    This will replace the ReusableListeners flag and simplify all tests using it.

It's not used as of this commit, and all the tests using the soon-to-be-legacy
approach still pass.
    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    36d18da View commit details
    Browse the repository at this point in the history

  13. *: adopt reusable listeners in all tests that restart 

    They didn't do this before, and as a result were susceptible to flakes.

They were discovered through the checks introduced in follow-up commits. It
will be impossible to hold it wrong.
    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a732de0 View commit details
    Browse the repository at this point in the history

  14. *: phase out ReusableListener bool

    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    27af371 View commit details
    Browse the repository at this point in the history

  15. loqrecovery: address a TODO

    @tbg
    tbg committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4e8a998 View commit details
    Browse the repository at this point in the history