Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: kvserver: disable replicate queue and lease transfers in closedts tests #108591

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 11, 2023

Backport 1/1 commits from #107531 on behalf of @tbg.

/cc @cockroachdb/release


For a more holistic suggestion on how to fix this for the likely many other
tests susceptible to similar issues, see:
#107528

1171 runs so far, 0 failures, over 15m55s

Fixes #101824.

Release note: None
Epic: none


Release justification:

@blathers-crl blathers-crl bot requested a review from a team as a code owner August 11, 2023 12:55
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 11, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 11, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-107531 branch from 31a3536 to 4f0a714 Compare August 11, 2023 12:55
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-107531 branch from bf3601e to 2d5729b Compare August 11, 2023 12:55
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker force-pushed the blathers/backport-release-22.2-107531 branch from 2d5729b to bd648df Compare August 12, 2023 10:03
For a more holistic suggestion on how to fix this for the likely many other
tests susceptible to similar issues, see:
#107528

Fixes #101824.

Release note: None
Epic: none
@erikgrinaker erikgrinaker force-pushed the blathers/backport-release-22.2-107531 branch from bd648df to 9eb871a Compare August 12, 2023 10:05
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Reminder: it has been 3 weeks please merge or close your backport!

@yuzefovich
Copy link
Member

stale PR

@yuzefovich yuzefovich closed this Jan 31, 2024
@yuzefovich yuzefovich deleted the blathers/backport-release-22.2-107531 branch January 31, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants