Initial checkin of Metrics LineGraph Component #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a screenshot? |
| @@ -23,6 +23,7 @@ | |||
| <link href='https://fonts.googleapis.com/css?family=Source+Sans+Pro:400,900|Source+Code+Pro' rel='stylesheet' type='text/css'> | |||
| <link rel="stylesheet" href="/css/app.css"> | |||
| <link rel="stylesheet" href="/css/rest_explorer.css"> <!-- TODO(andybons): @import-like behavior --> | |||
| <link rel="stylesheet" href="/css/graph.css"> <!-- TODO(andybons): @import-like behavior --> | |||
|
LGTM |
mrtracy
force-pushed
the
mtracy/graph_component
branch
from
e680ee4
to
2f4cf91
Compare
Commit creates the first version of a reusable LineGraph component, which graphs the results of cockroach time series query. It's a bit bare-bones in appearance, but is already reusable and should provide a good foundation for building our admin monitor pages.
mrtracy
force-pushed
the
mtracy/graph_component
branch
from
2f4cf91
to
0aca9d1
Compare
mrtracy
added a commit
that referenced
this pull request
May 22, 2015
Initial checkin of Metrics LineGraph Component
|
Matt, I think we shouldn't spend time doing our own graphs! Let's use: http://c3js.org/ |
|
There's also http://nvd3.org/ and http://fastly.github.io/epoch/ This one is pretty amazing: http://dc-js.github.io/dc.js/ Not bad for time series info: http://square.github.io/cubism/ |
|
Using a library is the plan, this checkin was mostly to 1. Get the data from our endpoint and 2. Make a mithril component that gets the data in a predictable way. The d3 stuff was just copy/pasted from one of d3's line chart demos. I spent some time to understand how the library worked at a basic level, but I was planning to go with the rickshaw library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit creates the first version of a reusable LineGraph component, which graphs
the results of cockroach time series query.
It's a bit bare-bones in appearance, but is already reusable and should provide
a good foundation for building our admin monitor pages.