ccl/cliccl: avoid opening Engine in debug encryption-decrypt #120547
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
jbowens
force-pushed
the
encryption-decrypt
branch
3 times, most recently
from
17d87b8
to
0b20a38
Compare
Adapt the `debug encryption-decrypt` command to avoid actually opening the Engine and instead only open the filesystem environment. This allows the command to be used even when missing or corrupt files prevent the Engine from being opened. Epic: none Fix cockroachdb#96699. Release note: none
jbowens
force-pushed
the
encryption-decrypt
branch
from
0b20a38
to
11371ae
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @sumeerbhola)
pkg/ccl/cliccl/ear_test.go line 163 at r1 (raw file):
cmd.SetOut(&b) cmd.SetErr(&b) require.NoError(t, cmd.Flags().Set("enterprise-encryption", encSpecStr))
I'm really perplexed as to how this test ever passed without this?
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/cliccl/ear_test.go line 163 at r1 (raw file):
Previously, jbowens (Jackson Owens) wrote…
I'm really perplexed as to how this test ever passed without this?
Ah, right, the file registry is not encrypted. I think this is a fine additional restriction to require the --enterprise-encryption flag, but lemme know your thoughts
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
pkg/ccl/cliccl/ear_test.go line 163 at r1 (raw file):
Previously, jbowens (Jackson Owens) wrote…
Ah, right, the file registry is not encrypted. I think this is a fine additional restriction to require the
--enterprise-encryptionflag, but lemme know your thoughts
I don't really have an opinion
|
TFTR! bors r=sumeerbhola |
|
Build succeeded: |
Adapt the
debug encryption-decryptcommand to avoid actually opening the Engine and instead only open the filesystem environment. This allows the command to be used even when missing or corrupt files prevent the Engine from being opened.Epic: none
Fix #96699.
Release note: none