-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: distsql: fix disk monitor leak on flow setup error #120561
release-23.2: distsql: fix disk monitor leak on flow setup error #120561
Conversation
Previously, it was possible for the flow disk monitor to be created in `newFlowContext` and never stopped. This monitor is connected to the long-living temp storage monitor, which accumulates all of its children as of recently, so this would become a memory leak that is now fixed. There is no release note given that the leak occurs only during error conditions that should be rare. Epic: None Release note: None
e745f9a
to
e4ffb1c
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball and @michae2)
Backport 1/1 commits from #120557 on behalf of @yuzefovich.
/cc @cockroachdb/release
Previously, it was possible for the flow disk monitor to be created in
newFlowContext
and never stopped. This monitor is connected to the long-living temp storage monitor, which accumulates all of its children as of recently, so this would become a memory leak that is now fixed.There is no release note given that the leak occurs only during error conditions that should be rare.
Informs: https://github.com/cockroachlabs/support/issues/2828
Epic: None
Release note: None
Release justification: bug fix.