-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backupccl: download pre restore data in cluster restore #124348
backupccl: download pre restore data in cluster restore #124348
Conversation
Epic: none Release note: none
These tables are already dropped and awaiting GC by the time we write the download job; why are we using download bandwidth and iops on something just to delete it? |
I don't really have strong opinions here, but i have 3 reasons:
I'm also happy to skip the check on cluster restores and move on though. |
As long as the "pre" spans are after the main spans I guess it doesn't matter; in a non-trivial restore they're already GC'ed and the vSSTs are gone anyway so it is a noop. |
This patch adds the pre restore data spans to the list of spans to download. While these pre restore spans map to data in the temporary system table database that are then rewwritten to the actual system table, the download job ought to download all external data linked into the cluster out of principle. Fixes cockroachdb#124330 Release note: none
6e76f55
to
be876f3
Compare
TFTR! bors r=dt |
This patch adds the pre restore data spans to the list of spans to download.
While these pre restore spans map to data in the temporary system table
database that are then rewwritten to the actual system table, the download job
ought to download all external data linked into the cluster out of principle.
Fixes #124330
Release note: none