Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/sqlbase: skip validation of FKs during drop #12514

Merged
merged 1 commit into from
Dec 21, 2016
Merged

sql/sqlbase: skip validation of FKs during drop #12514

merged 1 commit into from
Dec 21, 2016

Conversation

dt
Copy link
Member

@dt dt commented Dec 20, 2016 •
edited by rjnn
Loading

ValidateCrossTableReferences checks that the tables on both sides of
reference note that reference. However, the txn that moves a table to
the DROP state also removes the references to it, at which point that
validation no longer holds and should be skipped.

This change is Reviewable

@asubiotto
Copy link
Contributor

:lgtm: Referencing #9493 for posterity's sake.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@dt
sql/sqlbase: skip validation of FKs during drop
0b23a14 
ValidateCrossTableReferences checks that the tables on both sides of
reference note that reference. However, the txn that moves a table to 
the DROP state also removes the references to it, at which point that 
validation no longer holds and should be skipped.
@vivekmenezes
Copy link
Contributor

vivekmenezes commented Dec 21, 2016 via email •
edited by rjnn
Loading

@dt dt merged commit bda6f2f into cockroachdb:master Dec 21, 2016
@dt dt deleted the valfk branch January 22, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asubiotto asubiotto

@vivekmenezes vivekmenezes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dt @asubiotto @vivekmenezes