Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: add built-in "protobuf" data type support #127586

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XiaochenCui
Copy link
Contributor

@XiaochenCui XiaochenCui commented Jul 21, 2024

With the built-in "protobuf" type, the protobuf data which is stored in the database can be rendered as a human-readable format directly. It can also be queried and indexed directly.

The original issue is #47534.

Fixes: None

Release note: None

Copy link

blathers-crl bot commented Jul 21, 2024

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels Jul 21, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

With the built-in "protobuf" type, the protobuf data which is
stored in the database can be rendered as a human-readable format
directly. It can also be queried and indexed directly.

The original issue is cockroachdb#47534.

Fixes: None

Release note: None
Copy link

blathers-crl bot commented Jul 21, 2024

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@XiaochenCui
Copy link
Contributor Author

XiaochenCui commented Jul 21, 2024

@dt I'm working on a "protobuf" type proposal, this may simplifier queries with protobuf data.

@perezd
Copy link

perezd commented Jul 22, 2024

Have you considered proposing a schema registry for managing Protobuf descriptor data requirements within CDB? Our product offers a reflection API for hosted Protobuf modules that would be a very convenient way of delivering and managing the raw descriptor layouts for this RFC: https://buf.build/docs/bsr/introduction

If you're interested, I'd be happy to chat about it in Slack (I'm in the CDB community Slack).

@XiaochenCui
Copy link
Contributor Author

Have you considered proposing a schema registry for managing Protobuf descriptor data requirements within CDB? Our product offers a reflection API for hosted Protobuf modules that would be a very convenient way of delivering and managing the raw descriptor layouts for this RFC: https://buf.build/docs/bsr/introduction

If you're interested, I'd be happy to chat about it in Slack (I'm in the CDB community Slack).

Thanks for your information, I'll do some research in the next week and come back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants