-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: base, licenseccl: Revise resolution strategy for LicenseTTL #129878
release-23.1: base, licenseccl: Revise resolution strategy for LicenseTTL #129878
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
pkg/ui/ui.go
Outdated
if err != nil { | ||
log.Errorf(context.Background(), "unable to get license type: %+v", err) | ||
} | ||
licenseTTL := base.GetLicenseTTL(r.Context(), cfg.Settings, timeutil.DefaultTimeSource{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This snippet can be omitted since this old version doesn't surface license alerts in the UI. I might add them back in when we make further changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any by "can" I mean "has to be" because it's a compiler error :)
e6c1df5
to
31414a7
Compare
Previously, for resolving the cluster's license expiry we relied on a metric whose value was regularly ticked down by an async task. This change seeks to only the resolve value at read time by reading directly from the cluster settings when its requested. Release note: None Fixes: CRDB-40592 Epic: CRDB-8035
31414a7
to
1b41fe1
Compare
Backport 1/1 commits from #129052.
/cc @cockroachdb/release
Release justification: required telemetry changes for core modifications
Previously, for resolving the cluster's license expiry we relied on a metric
whose value was regularly ticked down by an async task. This change seeks to
only the resolve value at read time by reading directly from the cluster
settings when its requested.
Release note: None
Fixes: CRDB-40592
Epic: CRDB-8035