sql: make the backfill code use a limitNode for chunking. #13374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making the limit part of the semantic plan, distSQL will be able to use it. (Not yet tested since distSQL is not yet activated for backfilling.)
|
Hey I'm separately working on getting the backfill code to use distSQL. Is there any point to this PR? Thanks |
|
I'm ok with you taking over, as long as you ensure there's a limitNode in there (it was missing up to now). |
|
@RaduBerinde what do you think? |
|
Thanks for the change! I mainly care about |
|
I'm okay with you merging this |
|
Ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making the limit part of the semantic plan, distSQL will be able to use it.
(Not yet tested since distSQL is not yet activated for backfilling.)
Fixes #13368.
This change is