Fix TestServerNodeEventFeed on Multi-CPU #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Advance indexes until one or both slices are exhausted. | ||
| for i < len(expected) && j < len(actual) { | ||
| // If the current expected value matches the current actual value, | ||
| // advance both indexes. Otherwise, advance only the actual index. |
|
LGTM |
This test was encountering a race condition with an asynchronous background task, which affected its expected results on Multi-CPU test runs. Specifically, this test monitors the node event feed, recording all RPCs called on the node. However, in addition to the RPCs called by the test, there are also RPCs being called by the Node's "StoresScanner", which were showing up in the event feed. The exact ordering was unusually stable in single CPU tests, but the race is readily exposed in a multi-CPU test run. This *temporary* fix relaxes the final assertion of the test; the test still requires that it sees the events it generates directly, but now it will not fail if there are additional events that it did not expect. A better, permanent fix is suggested in the TODO.
mrtracy
force-pushed
the
mtracy/fix_servernodefeed_multi_cpu
branch
from
cb3debd
to
78f51dc
Compare
mrtracy
added a commit
that referenced
this pull request
Jun 23, 2015
…ulti_cpu Fix TestServerNodeEventFeed on Multi-CPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1436
This test was encountering a race condition with an asynchronous background
task, which affected its expected results on Multi-CPU test runs.
Specifically, this test monitors the node event feed, recording all RPCs called
on the node. However, in addition to the RPCs called by the test, there are also
RPCs being called by the Node's "StoresScanner", which were showing up in the
event feed. The exact ordering was unusually stable in single CPU tests, but the
race is readily exposed in a multi-CPU test run.
This temporary fix relaxes the final assertion of the test; the test still
requires that it sees the events it generates directly, but now it will not fail
if there are additional events that it did not expect.
A better, permanent fix is suggested in the TODO.