Minor fixes in the way of init & start #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,21 +155,21 @@ func initEngine(spec string) (storage.Engine, error) { | |||
| } | |||
| engine = storage.NewInMem(size) | |||
| } else { | |||
| // type, file = matches[3], matches[4] | |||
There was a problem hiding this comment.
We really do need a test for this.
|
Thanks for working on these fixes. Great to have more contributors! Could you resubmit this pull request using Phabricator (the details are in the README)? That's the code review tool we've settled on for the time being. It's certainly better than github, though I'm on the fence as to whether we should stick with phabricator or possibly move to stash. |
|
Sure thing. I'll take a look at Phabricator, and also look into the tests. |
|
closing as an updated version is being merged through Phabricator |
soniabhishek
pushed a commit
to soniabhishek/cockroach
that referenced
this pull request
Feb 15, 2017
committing missing file
irfansharif
pushed a commit
that referenced
this pull request
Aug 15, 2020
resync master to what's in-use by cockroach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Played around with it trying to boot it up, and fixed what I think were some fairly self-explanatory bugs on the way. With these changes, I can init a cluster (apparently successfully so), upon booting it complains about a missing default prefix in storage/prefix.go.