Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base: bump DefaultSendNextTimeout from 500ms to 10m #16205

Merged
merged 1 commit into from
May 30, 2017
Merged

base: bump DefaultSendNextTimeout from 500ms to 10m #16205

merged 1 commit into from
May 30, 2017

Conversation

petermattis
Copy link
Collaborator

Updates #15687

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@petermattis petermattis merged commit 0bfef5e into cockroachdb:master May 30, 2017
@petermattis petermattis deleted the pmattis/send-next-timeout branch May 30, 2017 16:59
@tbg
Copy link
Member

tbg commented May 30, 2017

LGTM

@tamird
Copy link
Contributor

tamird commented May 30, 2017

As always, it is good to include context in the commit message, rather than just referencing an issue.

Never mind, I see you included an extensive comment in the code 💯 Thanks!

:lgtm:

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

@bdarnell bdarnell mentioned this pull request Jun 5, 2017
Closed
@bdarnell bdarnell mentioned this pull request Jul 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-robinson a-robinson a-robinson approved these changes

@bdarnell bdarnell bdarnell approved these changes

@spencerkimball spencerkimball Awaiting requested review from spencerkimball

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petermattis @cockroach-teamcity @tbg @tamird @bdarnell @a-robinson