c-deps: import another rocksdb patch to avoid IngestExternalFile segfault #16931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault 985b5d7 imported a patch that fixed one IngestExternalFile segfault, but it appears there is another. Import "Fix TSAN: avoid arena mode with range deletions" [0], which seems to the trick. This patch has landed on master but is not in 5.5.1. [0]: facebook/rocksdb#2399 Fixes cockroachdb#16922.
|
This change is |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
985b5d7 imported a patch that fixed one IngestExternalFile segfault, but
it appears there is another. Import "Fix TSAN: avoid arena mode with
range deletions" [0], which seems to the trick. This patch has landed on
master but is not in 5.5.1.
Fixes #16922.