Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Slightly clarify the clock offset suicide error message #16943

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

a-robinson
Copy link
Contributor

We've had a couple users not be sure what it meant, hopefully this
helps.

@onkar, would this have helped you? It would have printed as:

fewer than half the known nodes are within the maximum clock offset of 500ms (0 of 1); check your machines' clock synchronization

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@petermattis
Copy link
Collaborator

:lgtm:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@bdarnell
Copy link
Contributor

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


pkg/rpc/clock_offset.go, line 230 at r1 (raw file):

		if numClocks > 0 && healthyOffsetCount <= numClocks/2 {
			return errors.Errorf(
				"fewer than half the known nodes are within the maximum clock offset of %s (%d of %d); "+

How about something like "clock synchronization error: This node is more than %s away from at least half the known nodes (%d of %d)"


Comments from Reviewable

@a-robinson
Copy link
Contributor Author

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


pkg/rpc/clock_offset.go, line 230 at r1 (raw file):

Previously, bdarnell (Ben Darnell) wrote…

How about something like "clock synchronization error: This node is more than %s away from at least half the known nodes (%d of %d)"

Sure, that's a bit clearer. Done.


Comments from Reviewable

We've had a couple users not be sure what it meant, hopefully this
helps.
@a-robinson a-robinson merged commit f2e0676 into cockroachdb:master Jul 10, 2017
@a-robinson a-robinson deleted the clockerr branch May 18, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants