cherrypick-1.1: build: separate out race logic tests #20542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the testrace build is going over 20min lately, so pulling logic tests (~15min) into their own build should help a bit. a follow up step might be to split default from the rest of the logic tests if testlogicrace is still the slowest build.
|
This change is |
|
Thanks! |
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this pull request
Feb 11, 2018
Newer branches have a more sophisticated solution for this (cockroachdb#20542)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic tests spin exceed the race detectors goroutine limit on 16 CPU machines, so the testlogicrace build in CI is pinned to 8 CPU machines. Unfortunately the release-1.1 branch does not split testrace and testlogicrace, so backport that split.
the testrace build is going over 20min lately, so pulling logic tests (~15min) into their own build should help a bit.
a follow up step might be to split default from the rest of the logic tests if testlogicrace is still the slowest build.