vendor: bump etcd/raft to pick up memory usage fix #27009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@bdarnell I looked through the changes that we picked up here and they didn't seem worrisome, but still - how proactive do we want to be about putting this on release-2.0? |
|
LGTM There's a typo in the commit message: we're picking up etcd-io/etcd#9887. I was planning to do a cherry-pick for release-2.0 today. |
craig bot
pushed a commit
that referenced
this pull request
Jun 28, 2018
27024: release-2.0: cherry-pick etcd-io/etcd#9887 r=tschottdorf a=bdarnell This is the release-2.0 counterpart to #27009. Release note (bug fix): Alleviate a scenario in which a large number of uncommitted Raft commands could cause memory pressure at startup time. Co-authored-by: Ben Darnell <ben@cockroachlabs.com>
tbg
force-pushed
the
bump-etcd
branch
2 times, most recently
from
dd5418a
to
e4928e7
Compare
|
TFTR. Commit message and PR title fixed. bors r=bdarnell |
Timed out |
Pick up etcd-io/etcd#9887, which avoids pulling the uncommitted portion of the Raft log into memory. Release note (bug fix): Alleviate a scenario in which a large number of uncommitted Raft commands could cause memory pressure at startup time.
|
Rebased. |
craig bot
pushed a commit
that referenced
this pull request
Jul 19, 2018
27009: vendor: bump etcd/raft to pick up memory usage fix r=bdarnell a=tschottdorf Pick up etcd-io/etcd#9887, which avoids pulling the uncommitted portion of the Raft log into memory. Release note (bug fix): Alleviate a scenario in which a large number of uncommitted Raft commands could cause memory pressure at startup time. Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Build succeeded |
|
So we put this in 2.0.4 but never merged it to master? Oops. |
|
Yep.
On Thu, Jul 19, 2018 at 3:31 PM Ben Darnell ***@***.***> wrote:
So we put this in 2.0.4 but never merged it to master? Oops.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27009 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135JwNa258kDs3eSiz2jlSVtdrgjACks5uIIpLgaJpZM4U5eu8>
.
--
…-- Tobias
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick up etcd-io/etcd#9887, which avoids pulling
the uncommitted portion of the Raft log into memory.
Release note (bug fix): Alleviate a scenario in which a large number of
uncommitted Raft commands could cause memory pressure at startup time.