kv: delete TestDelayedBeginRetryable, which was replaced by unit tests #34786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of cockroachdb#33523, this test doesn't really make sense. The transaction model is much more flexible to scenarios like this where a `PushTxn` is issued before the transaction's record is written. This flexibility required more targeted testing, which was added in cockroachdb#33523. As a result, we don't need such a high-level integration test any more. Instead, the following three subtests of `TestCreateTxnRecord` sufficiently test that such a situation is handled correctly and returns a retriable error like we were expecting: - `TestCreateTxnRecord/begin_transaction_after_end_transaction_(abort)` - `TestCreateTxnRecord/heartbeat_transaction_after_end_transaction_(abort)` - `TestCreateTxnRecord/end_transaction_(commit)_after_end_transaction_(abort)` Release note: None
|
This change is |
andreimatei
reviewed
Feb 12, 2019
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
|
bors r+ |
Build failed |
|
Bors compilation flake? Going for another round before diving in bors r+ |
Build failed (retrying...) |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Feb 12, 2019
34786: kv: delete TestDelayedBeginRetryable, which was replaced by unit tests r=nvanbenschoten a=nvanbenschoten As of #33523, this test doesn't really make sense. The transaction model is much more flexible to scenarios like this where a `PushTxn` is issued before the transaction's record is written. This flexibility required more targeted testing, which was added in #33523. As a result, we don't need such a high-level integration test any more. Instead, the following three subtests of `TestCreateTxnRecord` sufficiently test that such a situation is handled correctly and returns a retriable error like we were expecting: - `TestCreateTxnRecord/begin_transaction_after_end_transaction_(abort)` - `TestCreateTxnRecord/heartbeat_transaction_after_end_transaction_(abort)` - `TestCreateTxnRecord/end_transaction_(commit)_after_end_transaction_(abort)` Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #33523, this test doesn't really make sense. The transaction model
is much more flexible to scenarios like this where a
PushTxnis issuedbefore the transaction's record is written. This flexibility required
more targeted testing, which was added in #33523. As a result, we don't
need such a high-level integration test any more.
Instead, the following three subtests of
TestCreateTxnRecordsufficiently test that such a situation is handled correctly and
returns a retriable error like we were expecting:
TestCreateTxnRecord/begin_transaction_after_end_transaction_(abort)TestCreateTxnRecord/heartbeat_transaction_after_end_transaction_(abort)TestCreateTxnRecord/end_transaction_(commit)_after_end_transaction_(abort)Release note: None