docs: new RFC on logging modernization #51990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20200728-rfc-log
branch
12 times, most recently
from
53de666
to
c575081
Compare
|
Thanks @knz. This might be out of scope for this RFC, but what is the job of the For example, today customers request getting access to DDL events in their audit logs. However, DDL events are not recorded in audit logs so customers workaround that by querying |
|
I don't have an opinion about keeping There are arguments either way. |
This was referenced Jul 30, 2020
craig bot
pushed a commit
that referenced
this pull request
Aug 6, 2020
52200: util/log: improvements, simplifications and bug fixes r=irfansharif a=knz Fixes #52026 Fixes #52176 Fixes #52128 Fixes #51332 Supersedes #51499, #51410 For context, I was working on #51990, #51499 and #51410 when I stumbled upon bug #52128 in the logging package. I decided to clean up the code and fix that bug, and I ended up removing a lot of complexity and add many missing comments. Example CI output:  By removing the complexity, I removed the problem otherwise solved by #51499 & #51410 and I removed the source of the flake causing #52026 and #52176. Salient bits in this PR: - **util/log: reinforce the behavior of log file rotation** - "This patch "does the right thing" by opening the new file before switching over whatever redirection may have been set up from the old file to the new one." - **util/log: simplify TestLogScope+don't capture internal stderr writes** - "This complexity was thus removed and the doc clarified that TestLogScope is only valid under the default configuration, when there was no file output configured yet and no secondary loggers active yet." - "However we also have other reasons to dislike the stderr redirect in tests, so I decided to remove it here instead of conjuring new code." - **pgwire: un-skip TestauthenticationAndHBARules** Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
5 tasks
knz
force-pushed
the
20200728-rfc-log
branch
from
d43614f
to
b373b66
Compare
knz
force-pushed
the
20200728-rfc-log
branch
5 times, most recently
from
b994760
to
6445b78
Compare
26 tasks
knz
force-pushed
the
20200728-rfc-log
branch
from
6445b78
to
4450a0d
Compare
knz
force-pushed
the
20200728-rfc-log
branch
from
4450a0d
to
5a01d0a
Compare
|
Merging this as "completed" since the work was, in fact, completed. bors r+ |
|
Build failed: |
Release note: None
knz
force-pushed
the
20200728-rfc-log
branch
from
5a01d0a
to
1bbda55
Compare
|
bors r+ |
|
(Split all the eventlog-related changes into a different RFC, see #58374) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text of RFC here:
https://github.com/knz/cockroach/blob/20200728-rfc-log/docs/RFCS/20200728_log_modernization.md
Release note: None