release-20.2: backfill: clear bound account after index KV has been written #55092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were not clearing the bound account associated with the index backfiller, once the index KVs (which it was monitoring memory for) had been written and didn't need to be referenced in the future. This change clears the bound account after each "chunk" is processed by the index backfiller. Since the bound account is only used to track the memory of the index KVs generated when processing a "chunk", we can simply Clear() it instead of doing any fine grained shrinking. Release note: None
|
This change is |
pbardea
approved these changes
Oct 1, 2020
This was referenced Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #55051.
/cc @cockroachdb/release
Previously, we were not clearing the bound account associated
with the index backfiller once the index KVs (which it was
monitoring memory for) had been written and didn't need to
be referenced in the future.
This change clears the bound account after each "chunk" is
processed by the index backfiller. Since the bound account is
only used to track the memory of the index KVs generated when
processing a "chunk", we can simply Clear() it instead of doing
any fine grained shrinking.
Important to callout that clearing this bound account does not
affect the underlying row fetcher which has its own child monitor
and bound account to work with.
Release note: None