sql: bugfix to fractional year interval parsing #55230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
reviewed
Oct 6, 2020
| @@ -374,8 +374,9 @@ func TestPGIntervalSyntax(t *testing.T) { | |||
| {`1yr`, types.IntervalTypeMetadata{}, `1 year`, ``}, | |||
| {`1yrs`, types.IntervalTypeMetadata{}, `1 year`, ``}, | |||
| {`1.5y`, types.IntervalTypeMetadata{}, `1 year 6 mons`, ``}, | |||
| {`1.1y`, types.IntervalTypeMetadata{}, `1 year 1 mon 6 days`, ``}, | |||
| {`1.11y`, types.IntervalTypeMetadata{}, `1 year 1 mon 9 days 14:24:00`, ``}, | |||
| {`1.1y`, types.IntervalTypeMetadata{}, `1 year 1 mon`, ``}, | |||
There was a problem hiding this comment.
math.Mod can get tricky -- can you add tests for -1.1y?
There was a problem hiding this comment.
Added negative versions of all of these test cases and verified that it's the same in Postgres.
Previously, parsing an interval with a fractional year would produce an interval that was "too precise" compared to Postgres, which we aim to be compatible with. Postgres truncates the precision of fractional years in intervals to months; we did not. This commit fixes the issue. For example, '1.1 year'::interval will become '1 year 1 month' instead of a quantity with days and hours. Release note (sql change): parsing intervals with fractional years now produces intervals with no more precision than months, to match the behavior of Postgres.
jordanlewis
force-pushed
the
fractional-year
branch
from
018beb0
to
6100650
Compare
otan
approved these changes
Oct 6, 2020
|
TFTR! bors r+ |
|
Build succeeded: |
|
does this need a backport? either before or after 20.2.0? |
This was referenced Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, parsing an interval with a fractional year would produce an
interval that was "too precise" compared to Postgres, which we aim to be
compatible with. Postgres truncates the precision of fractional years in
intervals to months; we did not.
This commit fixes the issue. For example, '1.1 year'::interval will
become '1 year 1 month' instead of a quantity with days and hours.
Closes #55226.
Release note (sql change): parsing intervals with fractional years now
produces intervals with no more precision than months, to match the
behavior of Postgres.