sql: cleanup SURVIVE ... FAILURE syntax #56837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (sql change): SURVIVE AVAILABILITY ZONE FAILURE is now SURVIVE ZONE FAILURE.
|
This change is |
otan
force-pushed
the
survival_goal_2
branch
from
16c9fc7
to
1c9b561
Compare
otan
force-pushed
the
survival_goal_2
branch
from
1c9b561
to
31b59e7
Compare
We still need a concept of "default" for tree.SurviveDefault so that we do not display it syntactically, but the value will be transformed before it is persisted. Release note: None
otan
force-pushed
the
survival_goal_2
branch
from
31b59e7
to
37e64de
Compare
ajstorm
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
LGTM
Reviewed 5 of 5 files at r1, 11 of 11 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
thanks for the quick reviews bors r=ajstorm |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: remove SURVIVE DEFAULT; rename Survive to SurvivalGoal
We still need a concept of "default" for tree.SurviveDefault so that we
do not display it syntactically, but the value will be transformed
before it is persisted.
Release note: None
sql: rename SURVIVE AVAILABILITY ZONE FAILURE to SURVIVE ZONE FAILURE
Release note (sql change): SURVIVE AVAILABILITY ZONE FAILURE is now
SURVIVE ZONE FAILURE.