colflow: finish spans created by the outboxes #58741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Release note: None
yuzefovich
force-pushed
the
outbox-span
branch
from
1a38567
to
0ac0d79
Compare
asubiotto
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR! bors r+ |
|
bors r- |
|
Canceled. |
|
Sorry about that, I just came across it. It's increasingly going to be an anti-pattern to Finish() a span after grabbing the recording. I realize that's not at all what we do today in lots of places, but will be the world we're moving towards. For this PR, I made the relevant changes in https://github.com/cockroachdb/cockroach/pull/58712/files, in a way that follows that pattern. Sorry for the noise, I think we can close this. |
|
Oh ok, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #58721
Release note: None