tracing: elide tags from recording if not verbose #61116
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @irfansharif)
This avoids some of the obviously problematic expensive stringifications observed in cockroachdb#59379. Release justification: low-risk performance optimization that unblocks sql stats. Release note: None
`version.IsActive` unmarshals a protobuf (and this isn't trivial to fix), so let the tracer cache a positive result. This means that in the common case, IsActive is not on the hot path any more. Release justification: low-risk performance improvement Release note: None
tbg
force-pushed
the
tracing-nonverbose-tags
branch
from
95fc831
to
bec47d3
Compare
There was a problem hiding this comment.
Not very familiar with tracing yet, but an alternative might be to generate and memoize the tags on first use.
Reviewed 5 of 5 files at r3, 1 of 1 files at r4.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
|
bors r+
This is difficult with the way things currently work: tags are stringified ~once per Span, so memoization would have to live outside of the tracing package. But I agree that it would be workable. |
|
Build succeeded: |
This avoids some of the obviously problematic expensive stringifications
observed in #59379.
Release justification: low-risk performance optimization that unblocks sql stats.
Release note: None