sql: fix flaky batch size test #62604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
pkg/sql/colfetcher/vectorized_batch_size_test.go, line 72 at r1 (raw file):
assert.NoError(t, err) if foundBatches != 1 { t.Log(sb.String())
nit: why not return an error here? If returning the error outside of the loop, maybe we should do t.Log there as well so that the whole output is logged?
yuzefovich
reviewed
Mar 25, 2021
There was a problem hiding this comment.
Needs make bazel-generate.
Reviewable status:
Release note: None
jordanlewis
force-pushed
the
fix-batch-size-test
branch
from
d82630d
to
0ad1de6
Compare
|
bors r+ |
|
Build succeeded: |
This was referenced Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62576
Closes #62566
Release note: None