sql: use read ts as batch ts to send index backfill SSTs #64023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
force-pushed
the
index-sst-batch-ts
branch
3 times, most recently
from
8c636e6
to
68e92b5
Compare
ajwerner
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @pbardea)
|
TFTR! bors r+ |
This was referenced Apr 22, 2021
|
Build failed (retrying...): |
This changes SSTs sent by index backfills to be sent with a batch timestamp equal to the timestamp that was used to read the rows from which the index entries in that SST were generated. This is done to ensure that if the index span has already GCed any keys related to more recent SQL writes the SST will be rejected. Adding the SST generated from older writes could otherwise accidentally re-add an entry after a later SQL delete's tombstone had been GC'ed, as described in cockroachdb#64014. Release note (bug fix): fix a theoretical issue in index backfills that could result in stale entries that would likely fail validation (cockroachdb#64014).
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes SSTs sent by index backfills to be sent with a batch
timestamp equal to the timestamp that was used to read the rows from
which the index entries in that SST were generated.
This is done to ensure that if the index span has already GCed any
keys related to more recent SQL writes the SST will be rejected. Adding
the SST generated from older writes could otherwise accidentally re-add
an entry after a later SQL delete's tombstone had been GC'ed, as described
in #64014.
Release note (bug fix): fix a theoretical issue in index backfills that could result in stale entries that would likely fail validation (#64014).