Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: inline constant values for FK and uniqueness checks #65093

Closed
wants to merge 1 commit into from
Closed

opt: inline constant values for FK and uniqueness checks #65093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions pkg/ccl/logictestccl/testdata/logic_test/multi_region_tpcc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,8 @@ EXPLAIN INSERT
INTO
history (h_c_id, h_c_d_id, h_c_w_id, h_d_id, h_w_id, h_amount, h_date, h_data)
VALUES
(2057, 4, 3, 4, 3, 2100.9, '2021-04-15 15:22:14', '9 zmssaF9m')
(2057, 4, 3, 4, 3, 2100.9, '2021-04-15 15:22:14', '9 zmssaF9m'),
(2058, 4, 3, 4, 3, 2100.9, '2021-04-15 15:22:14', '9 zmssaF9m')
----
distribution: local
vectorized: true
Expand All @@ -204,8 +205,14 @@ vectorized: true
│ └── • buffer
│ │ label: buffer 1
│ │
│ └── • values
│ size: 11 columns, 1 row
│ └── • render
│ │ estimated row count: 2
│ │
│ └── • render
│ │ estimated row count: 2
│ │
│ └── • values
│ size: 8 columns, 2 rows
│
├── • constraint-check
│ │
Expand All @@ -218,7 +225,7 @@ vectorized: true
│ │ lookup condition: (((column3 = c_w_id) AND (column2 = c_d_id)) AND (column1 = c_id)) AND (crdb_region IN ('ca-central-1', 'us-east-1'))
│ │
│ └── • lookup join (anti)
│ │ estimated row count: 1
│ │ estimated row count: 2
│ │ table: customer@primary
│ │ equality cols are key
│ │ lookup condition: (((column3 = c_w_id) AND (column2 = c_d_id)) AND (column1 = c_id)) AND (crdb_region = 'ap-southeast-2')
Expand All @@ -237,7 +244,7 @@ vectorized: true
│ lookup condition: ((column5 = d_w_id) AND (column4 = d_id)) AND (crdb_region IN ('ca-central-1', 'us-east-1'))
│
└── • lookup join (anti)
│ estimated row count: 1
│ estimated row count: 2
│ table: district@primary
│ equality cols are key
│ lookup condition: ((column5 = d_w_id) AND (column4 = d_id)) AND (crdb_region = 'ap-southeast-2')
Expand Down
124 changes: 51 additions & 73 deletions pkg/ccl/logictestccl/testdata/logic_test/partitioning_implicit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,44 +238,42 @@ vectorized: true
├── • insert
│ │ into: fk_using_implicit_columns_against_t(pk, ref_t_pk, ref_t_c)
│ │
│ └── • buffer
│ │ label: buffer 1
│ │
│ └── • values
│ size: 3 columns, 1 row
│ └── • values
│ size: 3 columns, 1 row
│
├── • constraint-check
│ │
│ └── • error if rows
│ │
│ └── • hash join (right anti)
│ │ equality: (pk) = (column2)
│ │ left cols are key
│ │ right cols are key
│ └── • cross join (anti)
│ │
│ ├── • scan
│ │ missing stats
│ │ table: t@t_b_idx
│ │ spans: FULL SCAN
│ ├── • values
│ │ size: 1 column, 1 row
│ │
│ └── • scan buffer
│ label: buffer 1
│ └── • filter
│ │ filter: pk = 1
│ │
│ └── • scan
│ missing stats
│ table: t@primary
│ spans: [ - /0/1] [/1/1 - /1/1] [/2/1 - ]
│
└── • constraint-check
│
└── • error if rows
│
└── • hash join (right anti)
│ equality: (c) = (column3)
│ right cols are key
└── • cross join (anti)
│
├── • scan
│ missing stats
│ table: t@t_c_key
│ spans: FULL SCAN
├── • values
│ size: 1 column, 1 row
│
└── • scan buffer
label: buffer 1
└── • filter
│ filter: c = 4
│
└── • scan
missing stats
table: t@t_c_key
spans: [ - /2/4] [/3/4 - /3/4] [/4/4 - ]

statement ok
INSERT INTO fk_using_implicit_columns_against_t VALUES (1, 1, 4)
Expand Down Expand Up @@ -701,74 +699,54 @@ vectorized: true
├── • insert
│ │ into: t(pk, pk2, partition_by, a, b, c, d)
│ │
│ └── • buffer
│ │ label: buffer 1
│ │
│ └── • values
│ size: 8 columns, 1 row
│ └── • values
│ size: 8 columns, 1 row
│
├── • constraint-check
│ │
│ └── • error if rows
│ │
│ └── • hash join (right semi)
│ │ equality: (pk) = (column1)
│ │ right cols are key
│ │ pred: column3 != partition_by
│ └── • cross join
│ │
│ ├── • scan
│ │ missing stats
│ │ table: t@t_a_idx
│ │ spans: FULL SCAN
│ ├── • values
│ │ size: 1 column, 1 row
│ │
│ └── • scan buffer
│ label: buffer 1
│ └── • limit
│ │ count: 1
│ │
│ └── • filter
│ │ filter: pk = 1
│ │
│ └── • scan
│ missing stats
│ table: t@t_a_idx
│ spans: [ - /0] [/2 - ]
│
├── • constraint-check
│ │
│ └── • error if rows
│ │
│ └── • hash join (right semi)
│ │ equality: (b) = (column5)
│ │ right cols are key
│ │ pred: (column1 != pk) OR (column3 != partition_by)
│ └── • cross join
│ │
│ ├── • scan
│ │ missing stats
│ │ table: t@t_b_key
│ │ spans: FULL SCAN
│ ├── • values
│ │ size: 1 column, 1 row
│ │
│ └── • scan buffer
│ label: buffer 1
│ └── • limit
│ │ count: 1
│ │
│ └── • filter
│ │ filter: (b = 1) AND ((pk != 1) OR (partition_by != 1))
│ │
│ └── • scan
│ missing stats
│ table: t@t_b_key
│ spans: FULL SCAN
│
└── • constraint-check
│
└── • error if rows
│
└── • limit
│ count: 1
│
└── • lookup join
│ table: t@primary
│ equality: (partition_by, pk) = (partition_by,pk)
│ equality cols are key
│
└── • hash join
│ equality: (c) = (column6)
│ right cols are key
│ pred: (column1 != pk) OR (column3 != partition_by)
│
├── • scan
│ missing stats
│ table: t@t_c_key (partial index)
│ spans: FULL SCAN
│
└── • filter
│ estimated row count: 1
│ filter: column7 > 100
│
└── • scan buffer
label: buffer 1
└── • norows

statement ok
INSERT INTO t VALUES (1, 1, 1, 1, 1, 1, 1), (2, 2, 2, 2, 2, 2, 2)
Expand Down
97 changes: 77 additions & 20 deletions pkg/ccl/logictestccl/testdata/logic_test/regional_by_row
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,18 +977,23 @@ SELECT * FROM [EXPLAIN INSERT INTO child VALUES (1, 1)] OFFSET 2
│
└── • error if rows
│
└── • lookup join (anti)
│ table: parent@primary
│ equality cols are key
│ lookup condition: (column2 = p_id) AND (crdb_region IN ('ca-central-1', 'us-east-1'))
└── • cross join (anti)
│
├── • values
│ size: 1 column, 1 row
│
└── • lookup join (anti)
│ table: parent@primary
│ equality cols are key
│ lookup condition: (column2 = p_id) AND (crdb_region = 'ap-southeast-2')
└── • union all
│ limit: 1
│
└── • scan buffer
label: buffer 1
├── • scan
│ missing stats
│ table: parent@primary
│ spans: [/'ap-southeast-2'/1 - /'ap-southeast-2'/1]
│
└── • scan
missing stats
table: parent@primary
spans: [/'ca-central-1'/1 - /'ca-central-1'/1] [/'us-east-1'/1 - /'us-east-1'/1]

query T
SELECT * FROM [EXPLAIN UPSERT INTO child VALUES (1, 1)] OFFSET 2
Expand Down Expand Up @@ -1027,18 +1032,23 @@ SELECT * FROM [EXPLAIN UPSERT INTO child VALUES (1, 1)] OFFSET 2
│
└── • error if rows
│
└── • lookup join (anti)
│ table: parent@primary
│ equality cols are key
│ lookup condition: (column2 = p_id) AND (crdb_region IN ('ca-central-1', 'us-east-1'))
└── • cross join (anti)
│
└── • lookup join (anti)
│ table: parent@primary
│ equality cols are key
│ lookup condition: (column2 = p_id) AND (crdb_region = 'ap-southeast-2')
├── • values
│ size: 1 column, 1 row
│
└── • union all
│ limit: 1
│
└── • scan buffer
label: buffer 1
├── • scan
│ missing stats
│ table: parent@primary
│ spans: [/'ap-southeast-2'/1 - /'ap-southeast-2'/1]
│
└── • scan
missing stats
table: parent@primary
spans: [/'ca-central-1'/1 - /'ca-central-1'/1] [/'us-east-1'/1 - /'us-east-1'/1]

# We don't yet support locality optimized search for semi join.
query T
Expand Down Expand Up @@ -1101,6 +1111,53 @@ SELECT * FROM [EXPLAIN DELETE FROM parent WHERE p_id = 1] OFFSET 2
table: child@child_c_p_id_idx
spans: [/'us-east-1' - /'us-east-1']

# An insert FK check only needs to search a single region when the region is a
# computed column dependent on the FK column and a constant value is inserted.
statement ok
CREATE TABLE parent_comp (
pk INT PRIMARY KEY,
crdb_region crdb_internal_region AS (
CASE WHEN pk <= 10 THEN 'us-east-1' ELSE 'ap-southeast-2' END
) STORED,
FAMILY (pk, crdb_region)
) LOCALITY REGIONAL BY ROW;

statement ok
CREATE TABLE child_comp (
pk INT PRIMARY KEY,
p_pk INT REFERENCES parent_comp (pk),
crdb_region crdb_internal_region AS (
CASE WHEN pk <= 10 THEN 'us-east-1' ELSE 'ap-southeast-2' END
) STORED,
FAMILY (pk, p_pk, crdb_region)
) LOCALITY REGIONAL BY ROW;

query T
SELECT * FROM [EXPLAIN INSERT INTO child_comp VALUES (1, 1)] OFFSET 2
----
·
• root
│
├── • insert
│ │ into: child_comp(pk, p_pk, crdb_region)
│ │
│ └── • values
│ size: 4 columns, 1 row
│
└── • constraint-check
│
└── • error if rows
│
└── • cross join (anti)
│
├── • values
│ size: 1 column, 1 row
│
└── • scan
missing stats
table: parent_comp@primary
spans: [/'us-east-1'/1 - /'us-east-1'/1]

# Tests creating a index and a unique constraint on a REGIONAL BY ROW table.
statement ok
CREATE INDEX new_idx ON regional_by_row_table(a, b)
Expand Down
29 changes: 24 additions & 5 deletions pkg/sql/opt/exec/execbuilder/testdata/fk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,17 +999,36 @@ CREATE TABLE nonunique_idx_child (
CONSTRAINT "fk" FOREIGN KEY (ref1, ref2) REFERENCES nonunique_idx_parent (k1, k2)
)

# TODO(mgartner/radu): This query should use the insert fast path. Inlining the
# values removes the lookup join in the FK check that the insert fast path
# relies on.
query T
EXPLAIN INSERT INTO nonunique_idx_child VALUES (0, 1, 10)
----
distribution: local
vectorized: true
·
• insert fast path
into: nonunique_idx_child(k, ref1, ref2)
auto commit
FK check: nonunique_idx_parent@nonunique_idx_parent_k2_idx
size: 3 columns, 1 row
• root
│
├── • insert
│ │ into: nonunique_idx_child(k, ref1, ref2)
│ │
│ └── • values
│ size: 3 columns, 1 row
│
└── • constraint-check
│
└── • error if rows
│
└── • cross join (anti)
│
├── • values
│ size: 2 columns, 1 row
│
└── • scan
missing stats
table: nonunique_idx_parent@nonunique_idx_parent_k2_idx
spans: [/10/1 - /10/1]

# Regression test for #46397: upserter was looking at the incorrect ordinal for
# the check because of an extra input column used by the FK check.
Expand Down
Loading