Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: mark diagnostics.forced_stat_reset.interval as retired #65705

Merged
merged 1 commit into from
May 26, 2021

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented May 26, 2021

It was removed in ac3c723 but was never
added to this list. This prevents noise in the logs when trying to read
the old setting name.

Release note: None

It was removed in ac3c723 but was never
added to this list. This prevents noise in the logs when trying to read
the old setting name.

Release note: None
@rafiss rafiss requested review from otan and a team May 26, 2021 06:10
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator Author

rafiss commented May 26, 2021

cc @alistair-roacher -- this will fix the noisy logs you were asking me about.

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport? :D

@rafiss
Copy link
Collaborator Author

rafiss commented May 26, 2021

ty! flake seems unrelated

bors r=otan

@craig
Copy link
Contributor

craig bot commented May 26, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants