Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update cloud.google.com/go/storage to v1.16.0 #66993

Closed
wants to merge 1 commit into from

Conversation

adityamaru
Copy link
Contributor

@adityamaru adityamaru commented Jun 29, 2021

https://github.com/googleapis/google-cloud-go/releases/tag/storage%2Fv1.16.0 has the sought-after GOAWAY fix and is the latest release of the storage subpackage.

Release note: None

@adityamaru adityamaru requested a review from pbardea June 29, 2021 02:13
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor Author

The PR is likely going to run into make bazel_generate failing with:

ERROR: /private/var/tmp/_bazel_adityamaru/2592a7600a28e43d0b132c217219adf9/external/io_bazel_rules_go/BUILD.bazel:73:16: in go_context_data rule @io_bazel_rules_go//:go_context_data: cycle in dependency graph:
    //:gazelle
    //:gazelle-runner
    @bazel_gazelle//cmd/gazelle:gazelle
    @bazel_gazelle//language/go:go_default_library
    @bazel_gazelle//language/go:go
    @com_github_pelletier_go_toml//:go-toml
.-> @io_bazel_rules_go//:go_context_data
|   @io_bazel_rules_nogo//:nogo
|   @io_bazel_rules_go//:default_nogo
|   @io_bazel_rules_go//go/tools/builders:nogo_srcs
|   @org_golang_x_tools//go/analysis:go_tool_library
|   @org_golang_x_tools//internal/analysisinternal:go_tool_library
|   @org_golang_x_tools//go/ast/astutil:go_tool_library
|   @org_golang_x_tools//internal/typeparams:typeparams
`-- @io_bazel_rules_go//:go_context_data
ERROR: Analysis of target '//:gazelle' failed; build aborted

This looks similar to what #66880 is blocked on which is being tracked at bazel-contrib/rules_go#2479.

Copy link
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good (and took a look at the release notes); LGTM pending resolution of the Bazel blocker.

@adityamaru
Copy link
Contributor Author

Replaced by #67806

@adityamaru adityamaru closed this Jul 27, 2021
@adityamaru adityamaru deleted the bump-google-sdk branch July 27, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants