sql: UserHasAdminRole should return true for the admin role itself

[tukeJonny]

This PR makes planner.UserHasAdminRole returns true on the admin role for improving introspection.

This PR had checked by running make testbaselogic .

Fixes #70779

Release note: None

[blathers-crl]

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

• Please ensure your git commit message contains a release note.
• When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

• A person you worked with closely on this PR.
• The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
• Join our community slack channel and ask on #contributors.
• Try find someone else from here.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[cockroach-teamcity]

This change is 

[cockroach-teamcity]

All committers have signed the CLA.

[blathers-crl]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

• @rafiss (author of sql: UserHasAdminRole should return true for the admin role itself #70779)

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[rafiss]

ah, i thought we already had tests in place for this, but we don;t

could you add admin to the test case here:

cockroach/pkg/sql/logictest/testdata/logic_test/pg_catalog

Line 5359 in d36bb1a

WHERE usename IN ('super_user', 'regular_user', 'root')

[blathers-crl]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[tukeJonny]

@rafiss

I've added admin for testcase of pg_catalog.pg_user .
But, there were no records for admin in pg_catalog.pg_user , then tests had failed.

`make tesebaselogic FILES='pg_catalog'`

SELECT usename, usesuper
FROM pg_user
WHERE usename IN ('super_user', 'regular_user', 'root', 'admin')
ORDER BY usename;
        -- FAIL
    logic.go:2323: 
         
        testdata/logic_test/pg_catalog:5357: SELECT usename, usesuper
        FROM pg_user
        WHERE usename IN ('super_user', 'regular_user', 'root', 'admin')
        ORDER BY usename
        expected:
            usename       usesuper
            admin         true 
            regular_user  false
            root          true
            super_user    true
            
        but found (query options: "colnames") :
            usename       usesuper
            regular_user  false
            root          true
            super_user    true
        -- FAIL
    logic.go:1867: 
         testdata/logic_test/pg_catalog:5369: too many errors encountered, skipping the rest of the input
--- done: testdata/logic_test/pg_catalog with config local: 280 tests, 2 failures

From what i've been able to find out with make testbaselogic FILES='pg_catalog' , though admin role/user are exists, but can't see from pg_catalog.pg_user .

As following link, vtable iterates roles, and output simply. Therefore, I still can't find out cause of this problem.

https://github.com/cockroachdb/cockroach/blob/6ea317ddf277c6005589326d7ee68ea5003ceba2/pkg/sql/pg_catalog.go#L3006,L3036

Though i will do some more research on my end, please give me some advice if you have any ideas.

Thanks!

[tukeJonny]

When populating vtable.PGCatalogUser , isRole=true about admin user.
So, following if-statement passes and returns nil.

cockroach/pkg/sql/pg_catalog.go

Line 3008 in 6ea317d

if isRole {

From 20171220_sql_role_based_access_control.md

`isRole` denotes whether the corresponding name is a user or a role. Roles cannot log in or have passwords.

[rafiss]

i see, thanks for that investigation! in that case, this PR looks good! (there are other logictests that look up "admin" in other pg_catalog tables, and those already are correct)

bors r+

[tukeJonny]

Thanks for the great opportunity!

This Issue was just right and a good opportunity to look around and learn more!

[craig]

Build succeeded:

• GitHub CI (Cockroach)